From owner-cvs-all Sun Mar 19 18:18: 6 2000 Delivered-To: cvs-all@freebsd.org Received: from eclogite.eps.nagoya-u.ac.jp (eclogite.eps.nagoya-u.ac.jp [133.6.124.145]) by hub.freebsd.org (Postfix) with ESMTP id 8BA2837B879; Sun, 19 Mar 2000 18:18:00 -0800 (PST) (envelope-from kato@ganko.eps.nagoya-u.ac.jp) Received: from localhost (gneiss.eps.nagoya-u.ac.jp [133.6.124.148]) by eclogite.eps.nagoya-u.ac.jp (8.9.3/3.7W) with ESMTP id LAA32441; Mon, 20 Mar 2000 11:17:12 +0900 (JST) To: imp@village.org Cc: kato@ganko.eps.nagoya-u.ac.jp, asmodai@bart.nl, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/pc98 Makefile Makefile.inc src/sbin/pc98/fdisk Makefile fdisk.8 fdisk.c From: KATO Takenori In-Reply-To: Your message of "Sat, 18 Mar 2000 11:51:53 -0700" <200003181851.LAA97132@harmony.village.org> References: <200003181851.LAA97132@harmony.village.org> X-Mailer: Mew version 1.93 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA) X-PGP-Fingerprint: 03 72 85 36 62 46 23 03 52 B1 10 22 44 10 0D 9E Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20000320111642P.kato@gneiss.eps.nagoya-u.ac.jp> Date: Mon, 20 Mar 2000 11:16:42 +0900 X-Dispatcher: imput version 980905(IM100) Lines: 28 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Warner Losh wrote: > I think kato-san may be right here. Looks like there are many small > differences between a pc98 partition table and a pc-at partition > table. It is in a different format, there are 8 partitions rather > than 4, the ID codes for each partition are different, the cyl/sect > stuff is encoded differently, the basic units of measure are different > (cyl vs sector) etc. If this were a c++ program, then it might make > sense to have a partition base class, and two different derived > classes. But C and the structure of the current fdisk program > conspire to make that *MUCH* harder than it needs to be. Same problem exists also in libdisk. The libdisk contains `__alpha__ conditional', so `PC98 conditional' seems to be acceptable. But the structure of the partition table of Alphas is very similar to that of PC-ATs. On the contrary, the partition table of PC98 is quite different from that of PC-AT and Alpha. So, `PC98 conditional' may easily cause maintenance problem. The patch for libdisk is available from: http://freefall.FreeBSD.ORG/~kato/patches/libdisk.diff -----------------------------------------------+--------------------------+ KATO Takenori | FreeBSD | Dept. Earth Planet. Sci, Nagoya Univ. | The power to serve! | Nagoya, 464-8602, Japan | http://www.FreeBSD.org/ | |http://www.jp.FreeBSD.org/| ++++ FreeBSD(98) 3.3R-Rev. 01 available! +==========================+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message