From owner-freebsd-current@FreeBSD.ORG Fri Jan 11 09:09:57 2008 Return-Path: Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E08BB16A417 for ; Fri, 11 Jan 2008 09:09:57 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (unknown [IPv6:2a01:170:102f::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5132613C43E for ; Fri, 11 Jan 2008 09:09:57 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (localhost [127.0.0.1]) by lurza.secnetix.de (8.14.1/8.14.1) with ESMTP id m0B99thv097502; Fri, 11 Jan 2008 10:09:55 +0100 (CET) (envelope-from oliver.fromme@secnetix.de) Received: (from olli@localhost) by lurza.secnetix.de (8.14.1/8.14.1/Submit) id m0B99tlr097501; Fri, 11 Jan 2008 10:09:55 +0100 (CET) (envelope-from olli) Date: Fri, 11 Jan 2008 10:09:55 +0100 (CET) Message-Id: <200801110909.m0B99tlr097501@lurza.secnetix.de> From: Oliver Fromme To: freebsd-current@FreeBSD.ORG, atrens@nortel.com In-Reply-To: <47824627.40701@nortel.com> X-Newsgroups: list.freebsd-current User-Agent: tin/1.8.3-20070201 ("Scotasay") (UNIX) (FreeBSD/6.2-STABLE-20070808 (i386)) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.2 (lurza.secnetix.de [127.0.0.1]); Fri, 11 Jan 2008 10:09:56 +0100 (CET) Cc: Subject: Re: powerd adaptive mode latching X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsd-current@FreeBSD.ORG, atrens@nortel.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2008 09:09:58 -0000 Andrew Atrens wrote: > # cvs diff -u acpi_perf.c > Index: acpi_perf.c > =================================================================== > RCS file: /usr/repo/freebsd/src/sys/dev/acpica/acpi_perf.c,v > retrieving revision 1.26 > diff -u -r1.26 acpi_perf.c > - --- acpi_perf.c 22 Mar 2007 18:16:40 -0000 1.26 > +++ acpi_perf.c 16 Nov 2007 20:11:02 -0000 > @@ -300,9 +300,9 @@ > continue; > > /* Check for duplicate entries */ > - - if (count > 0 && > - - sc->px_states[count - 1].core_freq == > - - sc->px_states[count].core_freq) > + if (count > 0 && > + CPUFREQ_CMP(sc->px_states[count - 1].core_freq, > + sc->px_states[count].core_freq)) > continue; > > count++; > > > It's so simple that it's kind of silly that it (or something like it) > hasn't been committed yet... > > Anyone out there with a commit bit interested in submitting this ? It seems that nobody is responsible for those things right now (or nobody feels responsible). My PR bin/115513 is also still open. I'm using that patch for a long time already and wouldn't want to live without it; it improves interactive behaviour a lot on my notebook with powerd. Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "Being really good at C++ is like being really good at using rocks to sharpen sticks." -- Thant Tessman