From owner-freebsd-ports@FreeBSD.ORG Sat Sep 10 04:41:49 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 839DF106566B for ; Sat, 10 Sep 2011 04:41:49 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0783B8FC12 for ; Sat, 10 Sep 2011 04:41:48 +0000 (UTC) Received: by vxi39 with SMTP id 39so2451051vxi.13 for ; Fri, 09 Sep 2011 21:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=jvn39pyg/Xyf27U0qO8IUXQsYWXaKBgrSj5LePeWn5s=; b=Me/AiBHQWv45mJx0uA2oI9EkVAU4g5QRJYgATpWBw0ZdtlZ7nI3KLVxIu2M9LqkA73 o0N6AYI6vYdbTYfbOtTYX+JtsgqTknOXG/pNFMCpNhIvJNjrhRmguZtcY/ZNitEHI8B4 Eykitkrt7fMIJsPA+RsT8/PTsw+QMKp4XNTgM= Received: by 10.52.92.148 with SMTP id cm20mr453957vdb.109.1315629708246; Fri, 09 Sep 2011 21:41:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.180.72 with HTTP; Fri, 9 Sep 2011 21:41:18 -0700 (PDT) In-Reply-To: References: From: Eitan Adler Date: Sat, 10 Sep 2011 00:41:18 -0400 Message-ID: To: Aioanei Rares Content-Type: text/plain; charset=UTF-8 Cc: freebsd-ports@freebsd.org Subject: Re: Standalone mksh X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2011 04:41:49 -0000 > I wanted to propose the addition of a standalone mksh in shells/, which , of > course, is compiled with -static and installs to /bin . Attached is the > modified Makefile. 1) Please submit unified diffs, not entire files. It makes it easier to see what changed and it makes it easier to actually use when testing 2) We assume that LOCALBASE is read only (except for some very specific hacks like perl's symlink) so such a port will not be committed 3) Don't change PREFIX in the port's Makefile. This is a user specific option which should not be overwritten 4) If anything, the -static should be an OPTION. 5) Your change would require approval by the maintainer (miwi@FreeBSD.org). I would hope he does not approve it based on points 2-4 above. Thanks for your contribution. Please don't take my criticism of this specific patch as reason not to try again! -- Eitan Adler