From owner-svn-src-head@FreeBSD.ORG  Mon May 20 11:06:51 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 725925DA;
 Mon, 20 May 2013 11:06:51 +0000 (UTC)
 (envelope-from edschouten@gmail.com)
Received: from mail-ve0-x232.google.com (mail-ve0-x232.google.com
 [IPv6:2607:f8b0:400c:c01::232])
 by mx1.freebsd.org (Postfix) with ESMTP id 01C44DBA;
 Mon, 20 May 2013 11:06:50 +0000 (UTC)
Received: by mail-ve0-f178.google.com with SMTP id d10so3999219vea.23
 for <multiple recipients>; Mon, 20 May 2013 04:06:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=zZyBxbT+PcQIsdADy00NOPoyyh60UAyIuPAE7/5WT+4=;
 b=CFwF1BzJdROjaomZ19/dfxAgrRMfA5QhJWhReVBtlwopZSDAyU26Q+T3Q3ANHxru6h
 qBAxUV4L5jSQIqvm7kTNzZXlMeAl1cmrvFsv7OmzzuUusBftoeD88ExC+ltHgV0xHJRj
 xKX0QfbolphkdLd7DBbc/8oDb44Psy26E0mvFwVUz0EvnGz5TDBy4Qrg0MFQvaiDdw9W
 hhrCHTM5SZW4nej4X32Km+AB6Ht/CLR+dVonO/gpXerg5cbCwlRLswFp1gsw3vKkGPW7
 jIRGNuy7nz4wVmNq68UjLueIa8fvYt4xN4y1nc9qYiJMFvUEekPatnZKsATnOcB0svqp
 o9cg==
MIME-Version: 1.0
X-Received: by 10.52.185.164 with SMTP id fd4mr4361095vdc.19.1369048010500;
 Mon, 20 May 2013 04:06:50 -0700 (PDT)
Sender: edschouten@gmail.com
Received: by 10.220.72.7 with HTTP; Mon, 20 May 2013 04:06:50 -0700 (PDT)
In-Reply-To: <20130519094813.GA1465@mole.fafoe.narf.at>
References: <201305190744.r4J7i2FD055067@svn.freebsd.org>
 <20130519094813.GA1465@mole.fafoe.narf.at>
Date: Mon, 20 May 2013 13:06:50 +0200
X-Google-Sender-Auth: S5jEnNCcxayxokggwv1l6iZp1P0
Message-ID: <CAJOYFBC3Ww-jdy2cm7QNEbVzrZJHaeo3y797BVYp53pKJ5e-Nw@mail.gmail.com>
Subject: Re: svn commit: r250806 - head/sys/sys
From: Ed Schouten <ed@80386.nl>
To: Stefan Farfeleder <stefanf@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 May 2013 11:06:51 -0000

Hi Stefan,

2013/5/19 Stefan Farfeleder <stefanf@freebsd.org>:
> Shouldn't we fix lint and our headers to use a different macro name? One
> starting with __?

Fixing lint: yes. Changing our macros to use a different name: no.

The reason why we had __volatile, __inline, etc. in the first place,
was because adding definitions for volatile and inline directly would
be against the standard, as these words can be used freely in <C99.
C11 only added keywords starting with _[A-Z], which is reserved by all
the older standards, meaning we are completely free to define them in
any way we like.

This specific breakage was unrelated to the naming of the keyword. The
breakage existed, because existing tools do a build with -Dlint set.
Because we use _Thread_local in our own header files already
(runetype.h, I think), this caused a variable declared in a header
file to be of the wrong kind (TLS vs non-TLS).

In my opinion we should not add __[a-z] definitions for things that
are part of C11. Doing this only makes our code less easily exportable
to other systems.

--
Ed Schouten <ed@80386.nl>