Date: Tue, 28 Jul 2020 11:34:07 +0000 From: "Marcel Bischoff" <marcel@herrbischoff.com> To: freebsd-ports@freebsd.org Subject: Use of GH_ACCOUNT variable Message-ID: <01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@eu-west-1.amazonses.com>
next in thread | raw e-mail | index | archive | help
Hi all, I was initially involved in updating a port without maintainer = (multimedia/ffmpegthumbnailer), which was taken over by someone else. = I'm just starting out with porting and have updated several outdated = ones already. So that's fine. What irritates me however, is the conflicting information I got and the = differing styles of how GitHub downloads of source code are supposed to = be implemented. The Porter's Handbook is not completely clear on that as = well. In = https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefi= le-distfiles.html, = section 5.4.3, there's this: "If the distribution file comes from a = specific commit or tag on GitHub for which there is no officially = released file, there is an easy way to set the right DISTNAME and = MASTER_SITES automatically." This got interpreted in = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248095#c5 as having t= o = use the officially released file =E2=80=94 which I understand. Grepping for examples in the ports tree, I came up with a solution as = follows: MASTER_SITES=3D https://github.com/${GH_ACCOUNT}/${PORTNAME}/releases/dow= nload/${PORTVERSION}/ GH_ACCOUNT=3D dirkvdb In the latest proposed patch the GH_ACCOUNT variable was removed and = MASTER_SITES changed to: MASTER_SITES=3D https://github.com/dirkvdb/${PORTNAME}/releases/download/= ${PORTVERSION}/ Also, there's a magic GH for MASTER_SITES that does not download a = separate release but a specific tag, which somewhat contradicts the = interpretation of 5.4.3 to use a release file if available. Grepping the = ports tree surfaces several differing strategies, which all work but are = all in different style. I'd like to know if I missed something, if there is some unwritten = understanding on how to do this properly or if this is simply such a = small stylistic choice that it's up to whoever maintains or updates the = port. In case neither of the before apply, I'd like to encourage = agreeing on an official style that gets documented with an example. Thanks, Marcel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000>