From owner-freebsd-ports@freebsd.org Tue Jul 28 11:34:11 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 130F73A6D3D for ; Tue, 28 Jul 2020 11:34:11 +0000 (UTC) (envelope-from 01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@mx.herrbischoff.com) Received: from a4-2.smtp-out.eu-west-1.amazonses.com (a4-2.smtp-out.eu-west-1.amazonses.com [54.240.4.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BGF1s6Ltvz4Hyd for ; Tue, 28 Jul 2020 11:34:09 +0000 (UTC) (envelope-from 01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@mx.herrbischoff.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=upz6uqbfs7gpwvxptsow2lvxfyngeco2; d=herrbischoff.com; t=1595936047; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=o/th4KYnNNnfwa8M/MJwwwlY4Mo2R+DrpvlTuHcGFAU=; b=FDRWAZrNg5a4e0ugumg6Mk+LZspE1bsGxmRatELjMckj7CZ6r7YwdjVyVOwVoFwR hIL08X0EibCsP/OqXmIiPbVgQlM1v6UNd1eO3AOvMsF6WKNb2W1t49o05+C5oZWY2ew 68mtV45SCQmY5tmQYPn1C98du+p/w92GP6JKDQu0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=shh3fegwg5fppqsuzphvschd53n6ihuv; d=amazonses.com; t=1595936047; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=o/th4KYnNNnfwa8M/MJwwwlY4Mo2R+DrpvlTuHcGFAU=; b=jUjSMte7++Dw4vSlUJn4KUd7ZJDl4suhTOOEYv4gobg/PX32gVBHxW1VzxqqXOn1 Rjy7msemvvGo41SC1aa1QTl5+G9t/b8KSGdl1o8X2gBcQYlbCGkhKIkU4PsGo+nu2Sw rpxl5GH0dXOMPHxWKUtghQ/zMrUJB/nD4aBFf2QI= X-Virus-Scanned: amavisd-new at kryten.herrbischoff.com From: "Marcel Bischoff" To: freebsd-ports@freebsd.org Subject: Use of GH_ACCOUNT variable Date: Tue, 28 Jul 2020 11:34:07 +0000 Message-ID: <01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@eu-west-1.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-SES-Outgoing: 2020.07.28-54.240.4.2 Feedback-ID: 1.eu-west-1.zfjIIpqymtcz7r33MlIUbjqFzxRqfJcYJy40G2nVmTA=:AmazonSES X-Rspamd-Queue-Id: 4BGF1s6Ltvz4Hyd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=herrbischoff.com header.s=upz6uqbfs7gpwvxptsow2lvxfyngeco2 header.b=FDRWAZrN; dkim=pass header.d=amazonses.com header.s=shh3fegwg5fppqsuzphvschd53n6ihuv header.b=jUjSMte7; dmarc=pass (policy=none) header.from=herrbischoff.com; spf=pass (mx1.freebsd.org: domain of 01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@mx.herrbischoff.com designates 54.240.4.2 as permitted sender) smtp.mailfrom=01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@mx.herrbischoff.com X-Spamd-Result: default: False [-4.08 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.977]; R_DKIM_ALLOW(-0.20)[herrbischoff.com:s=upz6uqbfs7gpwvxptsow2lvxfyngeco2,amazonses.com:s=shh3fegwg5fppqsuzphvschd53n6ihuv]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:54.240.0.0/18]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-1.01)[-1.005]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[herrbischoff.com:dkim]; DKIM_TRACE(0.00)[herrbischoff.com:+,amazonses.com:+]; DMARC_POLICY_ALLOW(-0.50)[herrbischoff.com,none]; RCVD_IN_DNSWL_NONE(0.00)[54.240.4.2:from]; NEURAL_HAM_SHORT(-0.39)[-0.394]; FORGED_SENDER(0.30)[marcel@herrbischoff.com,01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@mx.herrbischoff.com]; RCVD_COUNT_ZERO(0.00)[0]; RWL_MAILSPIKE_POSSIBLE(0.00)[54.240.4.2:from]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16509, ipnet:54.240.0.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[marcel@herrbischoff.com, 01020173953380fa-17e3f0ab-566b-4e7f-9d15-286e6b6d01b6-000000@mx.herrbischoff.com] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 11:34:11 -0000 Hi all, I was initially involved in updating a port without maintainer = (multimedia/ffmpegthumbnailer), which was taken over by someone else. = I'm just starting out with porting and have updated several outdated = ones already. So that's fine. What irritates me however, is the conflicting information I got and the = differing styles of how GitHub downloads of source code are supposed to = be implemented. The Porter's Handbook is not completely clear on that as = well. In = https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefi= le-distfiles.html, = section 5.4.3, there's this: "If the distribution file comes from a = specific commit or tag on GitHub for which there is no officially = released file, there is an easy way to set the right DISTNAME and = MASTER_SITES automatically." This got interpreted in = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248095#c5 as having t= o = use the officially released file =E2=80=94 which I understand. Grepping for examples in the ports tree, I came up with a solution as = follows: MASTER_SITES=3D https://github.com/${GH_ACCOUNT}/${PORTNAME}/releases/dow= nload/${PORTVERSION}/ GH_ACCOUNT=3D dirkvdb In the latest proposed patch the GH_ACCOUNT variable was removed and = MASTER_SITES changed to: MASTER_SITES=3D https://github.com/dirkvdb/${PORTNAME}/releases/download/= ${PORTVERSION}/ Also, there's a magic GH for MASTER_SITES that does not download a = separate release but a specific tag, which somewhat contradicts the = interpretation of 5.4.3 to use a release file if available. Grepping the = ports tree surfaces several differing strategies, which all work but are = all in different style. I'd like to know if I missed something, if there is some unwritten = understanding on how to do this properly or if this is simply such a = small stylistic choice that it's up to whoever maintains or updates the = port. In case neither of the before apply, I'd like to encourage = agreeing on an official style that gets documented with an example. Thanks, Marcel