Date: Sun, 7 Sep 2014 13:53:31 -0700 From: yaneurabeya@gmail.com To: Antoine Brodin <antoine@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@freebsd.org> Subject: Re: svn commit: r269603 - in head: etc/mtree lib/libnv lib/libnv/tests tools/regression/lib/libnv Message-ID: <D316B9CC-199D-405A-BFD7-A51865C2FA32@gmail.com> In-Reply-To: <CAALwa8nHXs_8OH%2B3B--4os9yoHfM7dEaRpeMYXbtq37%2BOaqatA@mail.gmail.com> References: <53e12558.5d33.563f584f@svn.freebsd.org> <CAALwa8nHXs_8OH%2B3B--4os9yoHfM7dEaRpeMYXbtq37%2BOaqatA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sep 7, 2014, at 11:57, Antoine Brodin <antoine@freebsd.org> wrote: > On Tue, Aug 5, 2014 at 8:41 PM, Garrett Cooper <ngie@freebsd.org> wrote: >> Author: ngie >> Date: Tue Aug 5 18:41:27 2014 >> New Revision: 269603 >> URL: http://svnweb.freebsd.org/changeset/base/269603 >> >> Log: >> Integrate lib/libnv into the build/kyua >> >> Rename all of the TAP test applications from <test> to <test>_test >> to match the convention described in the TestSuite wiki page >> >> Phabric: D538 >> Approved by: jmmv (mentor) >> Sponsored by: EMC / Isilon Storage Division >> >> Added: >> head/lib/libnv/tests/ >> head/lib/libnv/tests/Makefile (contents, props changed) >> head/lib/libnv/tests/nvlist_add_test.c >> - copied unchanged from r269562, head/tools/regression/lib/libnv/nvlist_add.c >> head/lib/libnv/tests/nvlist_exists_test.c >> - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_exists.c >> head/lib/libnv/tests/nvlist_free_test.c >> - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_free.c >> head/lib/libnv/tests/nvlist_get_test.c >> - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_get.c >> head/lib/libnv/tests/nvlist_move_test.c >> - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_move.c >> head/lib/libnv/tests/nvlist_send_recv_test.c >> - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_send_recv.c >> Deleted: >> head/tools/regression/lib/libnv/ >> Modified: >> head/etc/mtree/BSD.tests.dist >> head/lib/libnv/Makefile > > Hi, > > It seems that after this commit libnv moved from /lib to /usr/lib. You’re right. SHLIBDIR is being overridden from bsd.own.mk. This patch will fix it: $ git diff diff --git a/lib/libnv/Makefile b/lib/libnv/Makefile index cad1ea4..4a7c76a 100644 --- a/lib/libnv/Makefile +++ b/lib/libnv/Makefile @@ -1,9 +1,10 @@ # $FreeBSD$ +SHLIBDIR?= /lib + .include <src.opts.mk> LIB= nv -SHLIBDIR?= /lib SHLIB_MAJOR= 0 SRCS= dnvlist.c $ make -VSHLIBDIR /lib I’ll put it out for review soon. Thanks :)! -Garrett [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUDMXLAAoJEMZr5QU6S73euMUH/2gGjsUARzHoEVUsozY9+e6F zq+//GCGNmrcWBpAFwGryskuWbODKbnrGu/YJRCWMdRVvAs7mf+vdVuTjnbFG/oc Yx0VVodburzI6zAFym3Rr64zw/e4S6wgE9EKx78ipP/3ZVA784KSuQFNaX8uU10b 2VRfwhI0IekIo8J2XrliI4FVZEL2mFUbeB0S5iY5xjlObNK1oOS1i9k3CbM+sfj3 ASASNFfZSed0fCYeXr84dBFPvybLxeY2fRXuV55x/pKVyNVTPcsiqTFiHj6qMsj3 dv1TnLqcbfLoZB8WBBhvY0+6407axSUtoNl9tpshCRAOt3b4d3Elk9XKbM8Y5bg= =Tbn3 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D316B9CC-199D-405A-BFD7-A51865C2FA32>