Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 08 Jul 2017 08:11:00 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 220548] "make cargo-crates" doesn't strip branch name
Message-ID:  <bug-220548-13-PsYHHOZFUG@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-220548-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-220548-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220548

--- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> ---
(In reply to Jan Beich from comment #1)
Looking at [1] I think we would need to strip ?tag=3D as well.

A dependency of e.g.

libc =3D {git =3D "https://github.com/rust-lang/libc", tag =3D "0.2.26"}

in Cargo.toml results in

[[package]]
name =3D "libc"
version =3D "0.2.26"
source =3D
"git+https://github.com/rust-lang/libc?tag=3D0.2.26#288942e6858a4b2f8ee5633=
8da5386263b9c4b82"

in Cargo.lock and then the wrong GH_TUPLE output again:

GH_TUPLE=3D=20=20=20=20=20=20
rust-lang:libc?tag=3D0.2.26:288942e6858a4b2f8ee56338da5386263b9c4b82:libc

which (given that we have an actual tag) probably should be

GH_TUPLE=3D       rust-lang:libc:0.2.26:libc

[1]
https://github.com/rust-lang/cargo/blob/master/src/doc/specifying-dependenc=
ies.md#specifying-dependencies-from-git-repositories

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220548-13-PsYHHOZFUG>