From owner-svn-src-head@freebsd.org Thu Dec 24 19:47:14 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD274A503AB; Thu, 24 Dec 2015 19:47:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 83AB41939; Thu, 24 Dec 2015 19:47:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pa0-x22e.google.com with SMTP id cy9so69820979pac.0; Thu, 24 Dec 2015 11:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rjo0IatzdEeO4YOlYWOa2Kcm/D6hN2vQGwUwewUdiHU=; b=CmTDS79p/GvYRj0vJZy0HIpPCsYgn1eFS1yAMSHHLE9XTNH/ehn2KaWI2hVB8k9T52 aM0d+2bPjGZ0srtl5C/tHTlTfvUc4Cj7gt4yQZV7i6HRxwV7qMwjqKOM70antnKPo4kq tbf/rlnYDL9qr2EePzJ8/vPpzzrybX8uVSJcJDuRio6wtIXaZfV63WAmvJhq2V+NOj2u 4lIt/o+Bf59SqnTfpCB5ZSVZ5oz/8jyQX66WYNTny6DfQJ9mIZW41VyonONLmE89/5qn xDuMh1JL4eFunilOTmgVwxcMPx9AQ6DaXh7/d8llfQYWLjFXi2Zs68G1d5n0VEq66Ntt ZdBQ== X-Received: by 10.66.137.38 with SMTP id qf6mr13323141pab.158.1450986434079; Thu, 24 Dec 2015 11:47:14 -0800 (PST) Received: from [100.193.219.245] ([172.56.42.5]) by smtp.gmail.com with ESMTPSA id 19sm19666914pfj.16.2015.12.24.11.47.12 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Dec 2015 11:47:12 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r291937 - in head: lib/libc/aarch64/sys lib/libc/arm/sys sys/arm/arm sys/arm/include sys/arm64/arm64 sys/arm64/include sys/conf sys/kern From: Garrett Cooper X-Mailer: iPhone Mail (13C75) In-Reply-To: <20151224180053.GY3625@kib.kiev.ua> Date: Thu, 24 Dec 2015 11:47:10 -0800 Cc: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <7B6C35A2-53E1-4424-A99A-904CB3DC9C1F@gmail.com> References: <201512071220.tB7CKRw0027858@repo.freebsd.org> <1450971642.25138.247.camel@freebsd.org> <20151224180053.GY3625@kib.kiev.ua> To: Konstantin Belousov X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 19:47:14 -0000 > On Dec 24, 2015, at 10:00, Konstantin Belousov wrote: > >> On Thu, Dec 24, 2015 at 08:40:42AM -0700, Ian Lepore wrote: >>> On Mon, 2015-12-07 at 12:20 +0000, Konstantin Belousov wrote: >>> Author: kib >>> Date: Mon Dec 7 12:20:26 2015 >>> New Revision: 291937 >>> URL: https://svnweb.freebsd.org/changeset/base/291937 >>> >>> Log: >>> Add support for usermode (vdso-like) gettimeofday(2) and >>> clock_gettime(2) on ARMv7 and ARMv8 systems which have architectural >>> generic timer hardware. It is similar how the RDTSC timer is used in >>> userspace on x86. >>> >>> Fix a permission problem where generic timer access from EL0 (or >>> userspace on v7) was not properly initialized on APs. >>> >>> For ARMv7, mark the stack non-executable. The shared page is added for >>> all arms (including ARMv8 64bit), and the signal trampoline code is >>> moved to the page. >>> >>> Reviewed by:> > andrew >>> Discussed with:> > emaste, mmel >>> Sponsored by:> > The FreeBSD Foundation >>> Differential revision:> https://reviews.freebsd.org/D4209 >> >> I've just discovered this change breaks buildworld on armv4/5 systems. >> Those systems don't have the counter hardware that can be read from >> userland (they don't have any common timer hardware at all, every >> system is different). Also, they don't support the 'mrrc' instruction, >> so the buildworld fails to compile libc. > > I tested the change with make universe. Is the armv5 world included > into the make ? If yes, there is something even more broken. > > That said, the code in __vdso_gettime.c is unused om armv4/v5 since kernel > never directs libc to use a fast timecounter. The routines could be left > undefined since they are declared weak, or the bodies could be stubbed out. > Anyway, to test, I should be able to compile libc for the target. > > And, BTW, what is exactly your error message ? It was an assembler error on stable/9 at least...