From owner-svn-src-all@FreeBSD.ORG Thu Nov 21 21:19:01 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90A9CACF; Thu, 21 Nov 2013 21:19:01 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 802FB26FE; Thu, 21 Nov 2013 21:19:01 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rALLJ11t062690; Thu, 21 Nov 2013 21:19:01 GMT (envelope-from eadler@svn.freebsd.org) Received: (from eadler@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id rALLJ1W3062689; Thu, 21 Nov 2013 21:19:01 GMT (envelope-from eadler@svn.freebsd.org) Message-Id: <201311212119.rALLJ1W3062689@svn.freebsd.org> From: Eitan Adler Date: Thu, 21 Nov 2013 21:19:01 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r258446 - head/usr.bin/from X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 21:19:01 -0000 Author: eadler Date: Thu Nov 21 21:19:01 2013 New Revision: 258446 URL: http://svnweb.freebsd.org/changeset/base/258446 Log: Add static where appropriate. Sync with some of DragonflyBSD's latest cleanups Reviewed by: mjg Modified: head/usr.bin/from/from.c Modified: head/usr.bin/from/from.c ============================================================================== --- head/usr.bin/from/from.c Thu Nov 21 21:05:11 2013 (r258445) +++ head/usr.bin/from/from.c Thu Nov 21 21:19:01 2013 (r258446) @@ -51,7 +51,7 @@ __FBSDID("$FreeBSD$"); #include #include -int match(const char *, const char *); +static int match(const char *, const char *); static void usage(void); int @@ -81,8 +81,7 @@ main(int argc, char **argv) case 's': sender = optarg; for (p = sender; *p; ++p) - if (isupper(*p)) - *p = tolower(*p); + *p = tolower(*p); break; case '?': default: @@ -142,7 +141,7 @@ usage(void) exit(1); } -int +static int match(const char *line, const char *sender) { char ch, pch, first; @@ -152,15 +151,14 @@ match(const char *line, const char *send if (isspace(ch = *line)) return(0); ++line; - if (isupper(ch)) - ch = tolower(ch); + ch = tolower(ch); if (ch != first) continue; for (p = sender, t = line;;) { if (!(pch = *p++)) return(1); - if (isupper(ch = *t++)) - ch = tolower(ch); + ch = tolower(*t); + t++; if (ch != pch) break; }