Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 May 2022 08:25:19 +0200
From:      Kirill Ponomarev <kp@krion.cc>
To:        =?iso-8859-1?Q?Mika=EBl?= Urankar <mikael@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 15b1da831b7c - main - lang/sbcl: Add aarch64 support
Message-ID:  <YnDKz7XfoE%2BFKmke@krion.cc>
In-Reply-To: <2fb8edc2-66c6-9c38-a60a-c27170d6f2f2@FreeBSD.org>
References:  <202205030531.2435VnSg087811@gitrepo.freebsd.org> <YnDFYGOh%2Bq013G0V@krion.cc> <2fb8edc2-66c6-9c38-a60a-c27170d6f2f2@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--qjZ3l4I3PAlMVZjj
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 05/03, Mika=EBl Urankar wrote:
> On 03/05/2022 08:02, Kirill Ponomarev wrote:
> > Did you test it before you merged it? It seems tarballs in distinfo are
> > missing.
> >
> > On 05/03, Mikael Urankar wrote:
> >> The branch main has been updated by mikael:
> >>
> >> URL:https://cgit.FreeBSD.org/ports/commit/?id=3D15b1da831b7cbebe2762fc=
cebcfb3b0d50b27fc9
> >>
> >> commit 15b1da831b7cbebe2762fccebcfb3b0d50b27fc9
> >> Author:     Mikael Urankar<mikael@FreeBSD.org>
> >> AuthorDate: 2022-04-04 11:00:54 +0000
> >> Commit:     Mikael Urankar<mikael@FreeBSD.org>
> >> CommitDate: 2022-05-03 05:22:17 +0000
> >>
> >>      lang/sbcl: Add aarch64 support
> >>     =20
> >>      PR:             261096
> >>      Reported by:    Robert Clausecker
> >>      Approved by:    krion (maintainer timeout)
> >> ---
> >>   lang/sbcl/Makefile | 15 ++++++++++-----
> >>   1 file changed, 10 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/lang/sbcl/Makefile b/lang/sbcl/Makefile
> >> index 5266d38ca984..b857d293f8f1 100644
> >> --- a/lang/sbcl/Makefile
> >> +++ b/lang/sbcl/Makefile
> >> @@ -18,7 +18,7 @@ LICENSE=3D	BSD2CLAUSE PD
> >>   LICENSE_COMB=3D	dual
> >>   LICENSE_FILE=3D	${WRKSRC}/COPYING
> >>  =20
> >> -ONLY_FOR_ARCHS=3D	amd64 i386
> >> +ONLY_FOR_ARCHS=3D	aarch64 amd64 i386
> >>  =20
> >>   LIB_DEPENDS=3D	libgmp.so:math/gmp \
> >>   		libmpfr.so:math/mpfr
> >> @@ -75,6 +75,8 @@ SAFEPOINT_VARS_OFF=3D	MAKE_SH_ARGS+=3D"--without-sb-=
safepoint --without-sb-thruption
> >>   SBCL_DISTFILES=3D	${PORTNAME}-${SBCL_BOOT_LIST:M${ARCHOS_PATTERN}}-b=
inary${EXTRACT_SUFX}:binaries
> >>   SBCL_VARS=3D	XC_HOST=3D"${BOOT_WRKSRC}/src/runtime/sbcl --core ${BOO=
T_WRKSRC}/output/sbcl.core --noinform --disable-debugger --no-sysinit --no-=
userinit"
> >>  =20
> >> +XC_HOST=3D"ecl"
> >> +
> >>   THREADS_VARS=3D		MAKE_SH_ARGS+=3D"--with-sb-thread"
> >>   THREADS_VARS_OFF=3D	MAKE_SH_ARGS+=3D"--without-sb-thread"
> >>  =20
> >> @@ -87,7 +89,10 @@ XREF_VARS_OFF=3D	MAKE_SH_ARGS+=3D"--without-sb-xref=
-for-internals"
> >>   ZLIB_VARS=3D	MAKE_SH_ARGS+=3D"--with-sb-core-compression"
> >>   ZLIB_VARS_OFF=3D	MAKE_SH_ARGS+=3D"--without-sb-core-compression"
> >>  =20
> >> -BOOTVERSION=3D	1.2.7
> >> +BOOTVERSION=3D		${BOOTVERSION_${ARCH}}
> >> +BOOTVERSION_aarch64=3D	2.2.0
> >> +BOOTVERSION_i386=3D	1.2.7
> >> +BOOTVERSION_amd64=3D	1.2.7
> >>   CONMODULES=3D	asdf sb-aclrepl sb-bsd-sockets sb-cltl2 sb-concurrency=
 sb-cover \
> >>   		sb-executable sb-gmp sb-grovel sb-introspect sb-md5 sb-mpfr \
> >>   		sb-posix sb-queue sb-rotate-byte sb-rt sb-simple-streams \
> >> @@ -98,12 +103,12 @@ MAKE_SH_ARGS?=3D	--prefix=3D"${PREFIX}" --xc-host=
=3D"${XC_HOST}"
> >>   .if defined(DYNAMIC_SPACE_SIZE)
> >>   MAKE_SH_ARGS+=3D	--dynamic-space-size=3D${DYNAMIC_SPACE_SIZE}
> >>   .endif
> >> -SBCL_BOOT_LIST=3D	${BOOTVERSION}-x86-64-freebsd ${BOOTVERSION}-x86-fr=
eebsd \
> >> -		${BOOTVERSION}-x86-64-dragonfly
> >> +SBCL_BOOT_LIST=3D	${BOOTVERSION}-arm64-freebsd ${BOOTVERSION}-x86-64-=
freebsd ${BOOTVERSION}-x86-freebsd \
> >> +		${BOOTVERSION}-x86-64-dragonfly \
> >>  =20
> >>   .include <bsd.port.options.mk>
> >>  =20
> >> -ARCHOS_PATTERN=3D	*-${ARCH:S/amd64/x86-64/:S/i386/x86/}-${OPSYS:tl}*
> >> +ARCHOS_PATTERN=3D	*-${ARCH:S/aarch64/arm64/:S/amd64/x86-64/:S/i386/x8=
6/}-${OPSYS:tl}*
> >>   BOOT_WRKSRC=3D	${WRKDIR}/${PORTNAME}-${SBCL_BOOT_LIST:M${ARCHOS_PATT=
ERN}}
> >>  =20
> >>   .if ${PORT_OPTIONS:MLINKABLE_RUNTIME}
>=20
> yes, I've done a poudriere testport before the commit on both aarch64 and=
 amd64.
> The testport was successfull on both arch
> I got a merged conflict and forgot to readd the distinfo for aarch64
> It's fixed in 1e4acb02a9bfdf003e20dd6627e2f49beeaa12e5

What I meant is did you test sbcl functionality on arm64, not building
it on poudriere.

--qjZ3l4I3PAlMVZjj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEJCHRFhEAQujKni1pDyI9/LMCykUFAmJwys8ACgkQDyI9/LMC
ykXNxwf+NDozBHlz/Fng5b7gIFeoWBq/GfXQtpGvijEeOuIL+GE/8vdeFo/cau85
kcYa66jBHQyk0lichAw+J4+8eGSZWmnwS5p6mXYFwAEy9s92QDhALKoaI5Elqo5i
FtqSh8mJGdqRiwZtuctwNdH6UH9wMpN0wSBqq1FmeJLGZavKgO4OeQ9YvXJ7ZIRm
ISnlmL5WZ3mAHBRItihgelcPzv1qSwdgzXM0lEKP/bsQtEub1xHeWTzyoxta9Xzc
AE7lHzOC6dEomK+mycNB3soxp5mXcMHboSsT+lUT0g07vrgpJXW7B4qxkj+QVj5a
trq6c+IEK+VoxG7z2IO5C4ZX7Nq8GQ==
=1LAs
-----END PGP SIGNATURE-----

--qjZ3l4I3PAlMVZjj--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YnDKz7XfoE%2BFKmke>