From owner-freebsd-mips@FreeBSD.ORG  Wed Aug 18 10:31:29 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F0F531065694
	for <freebsd-mips@freebsd.org>; Wed, 18 Aug 2010 10:31:29 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com
	[209.85.215.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 85C408FC18
	for <freebsd-mips@freebsd.org>; Wed, 18 Aug 2010 10:31:29 +0000 (UTC)
Received: by eyh6 with SMTP id 6so196656eyh.13
	for <freebsd-mips@freebsd.org>; Wed, 18 Aug 2010 03:31:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:in-reply-to
	:references:date:message-id:subject:from:to:content-type;
	bh=f1d5WUaFiJdF9UpJHpBgcKhgQldw2Jef6O8qRsHJmhA=;
	b=Lukos+ak/W9ce5vsTDEBiA4qfiix+PwF+NSU+g4pxFv5So6i1UuB+K1pKXS6T3ws62
	l1R7mYS6udE/6+no2ogUgl0cXumnxP8pYstPKXgxOEAp2hUjt/usn7ZvJOpo0pS6O7aF
	ee5u1oSCDtsi9JnEbzJbPXWyjG/F5P9gdv/oM=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type;
	b=U8qzsGxJshfqzrqzKB4MUUWL8/zXxMUl2mydCIZ9/j4N9L1N+qIACB6OS/zVe536Vo
	43V6IQzJAsysdxrwCDOz87T9yko9KpmCtmWvturApnlvecv2hfrzo29CIjJOD6quNLA5
	dsEquOPTbewYqOXIXqo4v6ZbhRYeFe4l/C91c=
MIME-Version: 1.0
Received: by 10.213.17.7 with SMTP id q7mr122793eba.23.1282127488360; Wed, 18
	Aug 2010 03:31:28 -0700 (PDT)
Received: by 10.213.108.205 with HTTP; Wed, 18 Aug 2010 03:31:28 -0700 (PDT)
In-Reply-To: <AANLkTikf0W2Scy1zgRk4u9GT8donG0yNw1R_p8SSxoAs@mail.gmail.com>
References: <AANLkTi=xyR8RVRjHBs-2qU8-WodHVysmmE=H66f7DfEi@mail.gmail.com>
	<AANLkTikf0W2Scy1zgRk4u9GT8donG0yNw1R_p8SSxoAs@mail.gmail.com>
Date: Wed, 18 Aug 2010 18:31:28 +0800
Message-ID: <AANLkTimG9-2_GntxmTQAiKYUN4XmJYHp-OFEJKcSrJwE@mail.gmail.com>
From: Adrian Chadd <adrian.chadd@gmail.com>
To: freebsd-mips@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: WIP: AR91XX (and AR724X, maybe) support
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2010 10:31:30 -0000

On 18 August 2010 13:39, Adrian Chadd <adrian.chadd@gmail.com> wrote:

> I'm going to commit the AR71XX specific bits and the CPU ops tonight.
> I can then convert over the bits of the codebase that needs CPU
> specific bits (WB prodding, USB setup, device enable/disable) without
> breaking the tree.
>
> I'll then commit the AR91XX and part of the AR724X support once I've
> rewritten the GPL bits.

This patch introduces the CPU ops to HEAD. I've done a couple of
preparation commits (register definitions, the CPU op struct
definition) before this, so you need to apply it to the latest HEAD.

http://people.freebsd.org/~adrian/rspro/atheros-ar71xx-cpuops.diff

Now I'm worried about this code being GPL contaminated. It's basically
a cut and paste from Linux, but the implementation is simple and
obvious enough to me that my re-implementation would look basically
the same.

I'd like a review for GPL-ness if possible. I'm happy to rewrite it
but it'd likely look quite a lot like how it does right now.

Thanks,


Adrian