From owner-svn-src-head@freebsd.org Thu Dec 7 21:36:15 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A0C7E91E85; Thu, 7 Dec 2017 21:36:15 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE6657766A; Thu, 7 Dec 2017 21:36:14 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f47.google.com with SMTP id z6so449117iti.4; Thu, 07 Dec 2017 13:36:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=bCNe5brmAthcX37NC2uY9jRNmMS/HCtVCVKsLmfkFLI=; b=d6teJ1TfzKkZHQCWPy7BKQOwhDffCt2WXVfqM3CLIEpJUc0iHWd2pwonpK5TNlOBah +WbKv/iBiPXXp2u7pu7evm8jqoaxaXMYqy9tdfjviWFbpxJWkE1l+6wEg3NomlqGA+oN MMCJgLE6xoICCm3d8Xxf/D3aL5naBUm+c2NxYvG0bXddGYuJt+ghn0E7hf4KzTr0f2dJ ia1tDWecDeoazkHSdqWTK/Z9v2uiWvZVO+HTj1Id+9N6edobqlq44fhq8Xp1hjGhh2xx 7Vy+51BvD4BJSrYORrPoOZX0ekXutjCv4xy3o7L2MAwRNJkfpSOmZew8oNIaeZsqmKz8 L8wA== X-Gm-Message-State: AKGB3mJ2WCEj9mFtI6uam2+gFIGEAJIkHXHzP3OZln4TInktQkuNQe3T nlR54d41ELfwQOuQw9pRv/aH1l8E X-Google-Smtp-Source: AGs4zMYe3lccAUxdFSEOVya4UBjaNAbSlYM+YAAzwjGsb2FgcvTYcUfTN0ZZLjwLasCMZOYHGL7Nrg== X-Received: by 10.36.23.151 with SMTP id 145mr3533006ith.28.1512682082073; Thu, 07 Dec 2017 13:28:02 -0800 (PST) Received: from mail-it0-f52.google.com (mail-it0-f52.google.com. [209.85.214.52]) by smtp.gmail.com with ESMTPSA id i63sm42138itb.35.2017.12.07.13.28.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:28:01 -0800 (PST) Received: by mail-it0-f52.google.com with SMTP id d16so415629itj.1; Thu, 07 Dec 2017 13:28:01 -0800 (PST) X-Received: by 10.107.158.193 with SMTP id h184mr39990087ioe.256.1512682081651; Thu, 07 Dec 2017 13:28:01 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.165.150 with HTTP; Thu, 7 Dec 2017 13:28:01 -0800 (PST) In-Reply-To: References: <201712071938.vB7Jc9Ck083315@repo.freebsd.org> From: Conrad Meyer Date: Thu, 7 Dec 2017 13:28:01 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r326664 - head/sys/vm To: Oliver Pinter Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 21:36:15 -0000 Read the phab review. On Thu, Dec 7, 2017 at 1:23 PM, Oliver Pinter wrote: > On 12/7/17, Mark Johnston wrote: >> Author: markj >> Date: Thu Dec 7 19:38:09 2017 >> New Revision: 326664 >> URL: https://svnweb.freebsd.org/changeset/base/326664 >> >> Log: >> Fix the UMA reclaim worker after r326347. >> >> atomic_set_*() sets a bit in the target memory location, so >> atomic_set_int(&uma_reclaim_needed, 0) does not do what it looks like >> it does. >> >> PR: 224080 >> Reviewed by: jeff, kib >> Differential Revision: https://reviews.freebsd.org/D13412 >> >> Modified: >> head/sys/vm/uma_core.c >> >> Modified: head/sys/vm/uma_core.c >> ============================================================================== >> --- head/sys/vm/uma_core.c Thu Dec 7 18:04:48 2017 (r326663) >> +++ head/sys/vm/uma_core.c Thu Dec 7 19:38:09 2017 (r326664) >> @@ -3177,7 +3177,7 @@ uma_reclaim_worker(void *arg __unused) >> EVENTHANDLER_INVOKE(vm_lowmem, VM_LOW_KMEM); >> sx_xlock(&uma_drain_lock); >> uma_reclaim_locked(true); >> - atomic_set_int(&uma_reclaim_needed, 0); >> + uma_reclaim_needed = 0; > > atomic_store_rel_int(&uma_reclaim_needed, 0) ? > >> sx_xunlock(&uma_drain_lock); >> /* Don't fire more than once per-second. */ >> pause("umarclslp", hz); >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >> >