From owner-freebsd-arch@FreeBSD.ORG Mon Dec 4 21:10:26 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7576316A417 for ; Mon, 4 Dec 2006 21:10:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3CCA43CAE for ; Mon, 4 Dec 2006 21:09:50 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kB4LAEx3041831; Mon, 4 Dec 2006 16:10:17 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-arch@freebsd.org Date: Mon, 4 Dec 2006 16:10:13 -0500 User-Agent: KMail/1.9.4 References: <45746791.5040807@errno.com> In-Reply-To: <45746791.5040807@errno.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200612041610.14195.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Mon, 04 Dec 2006 16:10:17 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2277/Mon Dec 4 12:10:23 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Subject: Re: CFR: NFS root options fixup X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2006 21:10:26 -0000 On Monday 04 December 2006 13:23, Sam Leffler wrote: > There's a small patch at: > > http://www.freebsd.org/~sam/nfsopts.patch > > to unify parsing of nfs mount options supplied when booting over the > net. It also extends the supported options so you can do things like > specify nolockd, tcp, udp, and nfsv2, nfsv3. Some of this appears to be > superfluous given the work that rc.initdiskless does but it's there. > > The one change I'm uncertain of is the bounds checking I apply to > rsize/wsize. > > Sam Do you need to set NFSMNT_RSIZE and NFSMNT_WSIZE in nd->flags in nfs_parse_options() if you get a "rsize" or "wsize" option? For the bootp case the flags are always set, but was worried about the non-bootp case. -- John Baldwin