From owner-svn-src-head@freebsd.org Sun Dec 9 21:24:20 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 29D7F13314B4 for ; Sun, 9 Dec 2018 21:24:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 729B47D22B for ; Sun, 9 Dec 2018 21:24:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id l11so10288922qtp.0 for ; Sun, 09 Dec 2018 13:24:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yWYE59L4pOsuKf8AY6yRLSCvVP9pGbicX6APbaO+DZc=; b=C04MHr1laa+U5d12K+STpdlzMj9dASnxox99Wh81sovE/JodxVKoTa+Hn9aKnfuNgJ 79eLV1mupWDgzrgDIzXFK/U0C4+0SbZRFY5C1WS04jBs2jBNrNqYSqC6ayw/9RozYOVj 0SnqpfydmEUpubBrRbGBnO1oScAc5P1AUCOxi4ZViwt0Jc46I3arFfldUWEBOcydLBEW jvkJqRwVyfIW3Y3Ko51kuAgEkmj0M67wecR8R7W3fSsym22zayh6N2EQ1ncwZ+B+v2jl SZgjxXcfYUUBZs2rk3XLT/7bl9P+2zExxHnLdxrZvgqt+DY6lKHmML1MGks6niQ704jf U3LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yWYE59L4pOsuKf8AY6yRLSCvVP9pGbicX6APbaO+DZc=; b=b89UQgu6L66Km8/U58fn7ZUrAChhKQXAwhS0s32ZO+FKntWiJ7/JHINn7odUuSJHQL kGfbnxF8YGQZDpG7euuPtzRJLzHp+D2YSKOp1jtdAr9Chd4o4txDeu4oAOeduxslzhcI yD7pSX4AjC0nbEfPYBQrLmrFTQ8GPMxmrYOwKaBV76nTv7swTCJNmQvlbrL+DZeofAT9 ILwN5Ila0Hz04sTntqw9RXaK/NydlYmQPO6A5agtUGXHPiwe3TLzIhPzVOUZOxw+ZFTR a8id2KhF+MA/0tlPAxUO3u17Zu0hr32RxRx9EoY7lN6IQNrZkowJoGLdPInmBxAHy79c fSJw== X-Gm-Message-State: AA+aEWZ8tcMwOzPYp3G4lhWA4n516iaDkkxhi6QVqs9sJabWUFWwwvWn 2WW5t/sUc569VgoxbMbV464IJX6eiVskevhEendHrw== X-Google-Smtp-Source: AFSGD/V0NZPj19Y4GV7JyvYcPD/QgKtJhuaGIk30NqSrZ2mlEkKEhHlCF+x1n1uQgTIL91vb1icU2vJP+wRowuFUXb8= X-Received: by 2002:ac8:668c:: with SMTP id d12mr9378416qtp.242.1544390658931; Sun, 09 Dec 2018 13:24:18 -0800 (PST) MIME-Version: 1.0 References: <201812090701.wB9711aN058754@slippy.cwsent.com> <201812091933.wB9JXOvW062964@pdx.rh.CN85.dnsmgr.net> In-Reply-To: From: Warner Losh Date: Sun, 9 Dec 2018 14:24:07 -0700 Message-ID: Subject: Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_c... To: Oliver Pinter Cc: "Rodney W. Grimes" , svn-src-head@freebsd.org, Cy Schubert , svn-src-all@freebsd.org, src-committers , Cy Schubert X-Rspamd-Queue-Id: 729B47D22B X-Spamd-Result: default: False [-4.55 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.73)[-0.733,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[a.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.81)[ip: (-6.20), ipnet: 2607:f8b0::/32(-1.49), asn: 15169(-1.30), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Dec 2018 21:24:20 -0000 On Sun, Dec 9, 2018 at 2:03 PM Oliver Pinter wrote: > > > On Sunday, December 9, 2018, Warner Losh wrote: > >> On Sun, Dec 9, 2018 at 1:09 PM Rodney W. Grimes < >> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >> >> > > In message <201812090645.wB96jnso066329@repo.freebsd.org>, Cy >> Schubert >> > > writes: >> > > > Author: cy >> > > > Date: Sun Dec 9 06:45:49 2018 >> > > > New Revision: 341759 >> > > > URL: https://svnweb.freebsd.org/changeset/base/341759 >> > > > >> > > > Log: >> > > > MFV r341618: >> > > > >> > > > Update wpa 2.6 --> 2.7. >> > > >> > > Relnotes: yes >> > >> > As an FYI, or maybe a new procedure, doing a reply to >> > a commit message adding relnotes: yes does very little >> > to insure that this commit gets refered to in release >> > notes. >> > >> > What about we add RELNOTES.missed to the tree >> > next to UPDATING, and when someone forgets to tag >> > the Relnotes:yes into a commit you just follow up >> > with a commit to that file, stating the svn revision >> > which was missing the note and then we have a nice >> > documented and clean way to extract the missing >> > release note items, rather than trying to cull it >> > from a thread in a mail list archive. >> > >> > The file would get truncated to 0 at appropriate >> > times on various branches. >> > >> >> How about just RELNOTES. You put the revision that is relevant and a quick >> blurb. That way we don't have to look in two places. All release notes go >> in here, no exceptions. You can retroactively tag them, or you can commit >> this as part of commit. > > >> > I don't really know SVN, but there wouldn't be a chicken egg probem during > commit time? I mean you would really know the SVN id. So you could only add > a specific revision in a different commit to RELEASE file. > Generally, you can guess really well, and fix it in the case of a lost race easily. You'd add the release notes text in full to the file, with a pointer to the revision(s) for the feature. Warner > >> Have a blurb at the top that tells people what >> order to add them in, and you'd be set. We'd then retire "relnotes: yes" >> in >> the commit message. This would also allow 'helpers' to format the RELNOTES >> file as we go rather than having to play 2 years of catch-up at major >> branch times. >> >> Having it in the commit message just doesn't work, and this is one of many >> reasons: Cy forgot. Other times I'll do something and it's only a month >> later I realize it needs to be in the release notes after some issue has >> come up.... Other times I put relnotes: yes in only to realize that's my >> vanity talking, and nobody else cares. >> >> Warner >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >> >