From owner-svn-src-all@freebsd.org  Fri Feb  5 10:25:38 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB0B3A77F90;
 Fri,  5 Feb 2016 10:25:38 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9BB0768F;
 Fri,  5 Feb 2016 10:25:38 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD))
 (envelope-from <slw@zxy.spb.ru>)
 id 1aRda4-000FH7-JC; Fri, 05 Feb 2016 13:25:36 +0300
Date: Fri, 5 Feb 2016 13:25:36 +0300
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@FreeBSD.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r294560 - head/etc/rc.d
Message-ID: <20160205102536.GY37895@zxy.spb.ru>
References: <201601221214.u0MCE8Jk054031@repo.freebsd.org>
 <56B3DE8E.9020603@FreeBSD.org> <56B3E55F.3040004@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56B3E55F.3040004@FreeBSD.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2016 10:25:39 -0000

On Thu, Feb 04, 2016 at 03:57:19PM -0800, Bryan Drewery wrote:

> On 2/4/2016 3:28 PM, Bryan Drewery wrote:
> > On 1/22/2016 4:14 AM, Dag-Erling Smørgrav wrote:
> >> Author: des
> >> Date: Fri Jan 22 12:14:08 2016
> >> New Revision: 294560
> >> URL: https://svnweb.freebsd.org/changeset/base/294560
> >>
> >> Log:
> >>   Do not generate RSA1 or DSA keys by default.
> >>
> >> Modified:
> >>   head/etc/rc.d/sshd
> >>
> >> Modified: head/etc/rc.d/sshd
> >> ==============================================================================
> >> --- head/etc/rc.d/sshd	Fri Jan 22 12:00:56 2016	(r294559)
> >> +++ head/etc/rc.d/sshd	Fri Jan 22 12:14:08 2016	(r294560)
> >> @@ -20,9 +20,9 @@ configtest_cmd="sshd_configtest"
> >>  pidfile="/var/run/${name}.pid"
> >>  extra_commands="configtest keygen reload"
> >>  
> >> -: ${sshd_rsa1_enable:="yes"}
> >> +: ${sshd_rsa1_enable:="no"}
> >>  : ${sshd_rsa_enable:="yes"}
> >> -: ${sshd_dsa_enable:="yes"}
> >> +: ${sshd_dsa_enable:="no"}
> >>  : ${sshd_ecdsa_enable:="yes"}
> >>  : ${sshd_ed25519_enable:="yes"}
> >>  
> >>
> > 
> > I think perhaps you should also remove these as having default paths in
> > the .c as well and require they be enabled in the config. Otherwise a
> > warning is given:
> > 
> > Feb  4 15:25:22 VM sshd[874]: error: Could not load host key:
> > /etc/ssh/ssh_host_dsa_key
> 
> This happens on every login even. It's quite annoying.

And no login too.