From owner-freebsd-ports@freebsd.org Thu Oct 1 21:25:40 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A86D4345FC for ; Thu, 1 Oct 2020 21:25:40 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C2R4N3f2Qz3TSd for ; Thu, 1 Oct 2020 21:25:40 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 5A47318933 for ; Thu, 1 Oct 2020 21:25:40 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f179.google.com with SMTP id n10so405565qtv.3 for ; Thu, 01 Oct 2020 14:25:40 -0700 (PDT) X-Gm-Message-State: AOAM532ieJ8ez6zBvJ9SzIXkrEriZ5Gs1SGJs/ADapOWrK+MvoS2s8UD U0HE/ihZ9jUEupfNw7ukiZ/AI83bpGVf7Hny9dc= X-Google-Smtp-Source: ABdhPJxVuPuyKlxRCs1I0q67DXLuF4RLD5o2tZB6Cx5zDOaaR3ukQpLmJd5MCKmWt3a2WCPyhetURGyW7OT+6n9WZP0= X-Received: by 2002:ac8:3261:: with SMTP id y30mr9932062qta.242.1601587539933; Thu, 01 Oct 2020 14:25:39 -0700 (PDT) MIME-Version: 1.0 References: <20201001211149.uhdi4w6xstjv4iw3@t470.schmi.tt> In-Reply-To: <20201001211149.uhdi4w6xstjv4iw3@t470.schmi.tt> From: Kyle Evans Date: Thu, 1 Oct 2020 16:25:26 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Patch compiler warnings away? To: Moritz Schmitt Cc: ports-list freebsd Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 21:25:40 -0000 On Thu, Oct 1, 2020 at 4:12 PM Moritz Schmitt wrote: > > Hi, > > I recently took over my first maintainership of a port and I have a > question regarding on how to deal with compiler warnings. > > The port is devel/cscope and it seems to be in a rather good shape. It > contains the newest version of cscope and it builds without any major > problems. However, when building it the compiler issues three warnings > that I could easily patch away. > > What's the recommended approach? Just ignore the warnings and don't > modify the software since it builds anyway? Or create patches even > though they don't seem to be strictly necessary? > > In any case, I will send the patches to the project in the hope that > they fix it upstream in the long run. > This is kind of your prerogative as the maintainer to do whatever you feel is right. Personally, I would usually not bother patching the port if I can easily send it upstream and they don't look like actual functional/security issues, *unless* I'm doing a version update anyways that would cause folks to rebuild the port -- then I might tack them on at the same time just so I can later point to the port and say "Hey, we've been running with these and everything is (fine / on fire)!" In any event, +1 for sending them upstream regardless. :-)