Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Jun 2023 16:27:55 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 271954] [NEW PORT] x11-wm/emwm Enhanced Motif Window Manager
Message-ID:  <bug-271954-7788-SwURJNQaAi@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-271954-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-271954-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271954

--- Comment #4 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for the update.  This is a lot better.  Portlint still shows a few
warnings though, perhaps you can check them?  It seems like it is confused
because you swapped the MAINTAINER and LICENSE blocks.

A test build reveals that you use the PORTDOCS variable despite no DOCS
variable being defined.  Either put the README file into pkg-plist or add a
DOCS option (probably overkill).

A build test succeeds but there is this warning:

WmError.c:121:24: warning: incompatible function pointer types passing 'void
(char *)' to parameter of type 'void (*)(S
tring) __attribute__((noreturn))' (aka 'void (*)(char *)
__attribute__((noreturn))') [-Wincompatible-function-pointer-t
ypes]=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20
    XtSetErrorHandler (WmXtErrorHandler);=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20
                       ^~~~~~~~~~~~~~~~=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
/usr/local/include/X11/Intrinsic.h:1776:1: note: passing argument to parame=
ter
here=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20
);=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
^=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20
1 warning generated.

This warning is known to have become an error in LLVM16, which will be the
default on FreeBSD 14.  Check if you can add a patch for it.  To test with
LLVM16, install devel/llvm16 and build with

    make CC=3Dclang16 CXX=3Dclang++16

I noticed that the MAINTAINER email address in the port is different from t=
he
one you use on bugzilla.  This may lead to problems as people will not
immediately see that you are the maintainer.  Also, we have hooks to
auto-notify the maintainer when a bug is files against one of his/her ports=
.=20
Are you okay with me changing the MAINTAINER address in the patch to the sa=
me
you use on bugzilla?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271954-7788-SwURJNQaAi>