From owner-dev-commits-src-all@freebsd.org Thu Apr 29 14:56:08 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F08A062D259; Thu, 29 Apr 2021 14:56:08 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FWJV03y7Yz4mJd; Thu, 29 Apr 2021 14:56:08 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.66.148.124]) by shaw.ca with ESMTPA id c85El2l1YMrQqc85FlEkCv; Thu, 29 Apr 2021 08:56:06 -0600 X-Authority-Analysis: v=2.4 cv=Nv6yz+RJ c=1 sm=1 tr=0 ts=608ac906 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=3YhXtTcJ-WEA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=ias3XygZLv0huwl5YZ4A:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 45D9A2955; Thu, 29 Apr 2021 07:56:03 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 13TEtxEg040285; Thu, 29 Apr 2021 07:55:59 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202104291455.13TEtxEg040285@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Michael Gmelin cc: Cy Schubert , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a0358e3d5184 - main - Synch index of contrib/bc with what is in workdir after cloning. In-reply-to: <20210429162959.16662d66@bsd64.grem.de> References: <202104291234.13TCYk5K092776@gitrepo.freebsd.org> <202104291353.13TDrIg3026309@slippy.cwsent.com> <20210429162959.16662d66@bsd64.grem.de> Comments: In-reply-to Michael Gmelin message dated "Thu, 29 Apr 2021 16:29:59 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 29 Apr 2021 07:55:58 -0700 X-CMAE-Envelope: MS4xfKf9gVODHrEAGrlWATgbaVI1X1H3y+IiqoR+2dxiCjHkO657oM7Mg1x3qeYFwdULyf9u9tsMtHpI8Ohuz4UN6tqTyIkztOrmO0gKPr24xP7BzP7++Y1A 6llmSeiqMsI1CdQQfDnX7VRLFC3scmO/FW++U4WecT5QG9xrZ/HskmKwu7627wFRil43bRC6JrtYtcf4Cd9Xuo5vN8H61aj56oEdKIH855xAkBlAkTDu+RD6 RRK41GBIGoDKw8X+LEKc8xSY2pk8n04xjIJhp1G8/7pWQZQrvJgv2PrbOb8PzMmtYd1uTFwOTGn/Te/4l8RMRFG+u19Z0+mWdYYk3VQSqVU= X-Rspamd-Queue-Id: 4FWJV03y7Yz4mJd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 14:56:09 -0000 In message <20210429162959.16662d66@bsd64.grem.de>, Michael Gmelin writes: > > > > On Thu, 29 Apr 2021 06:53:18 -0700 > Cy Schubert wrote: > > > In message <202104291234.13TCYk5K092776@gitrepo.freebsd.org>, Michael > > Gmelin wr > > ites: > > > The branch main has been updated by grembo (ports committer): > > > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=a0358e3d5184950b4316f105eb292cba > > > fdea208b > > > > > > commit a0358e3d5184950b4316f105eb292cbafdea208b > > > Author: Michael Gmelin > > > AuthorDate: 2021-04-29 12:29:04 +0000 > > > Commit: Michael Gmelin > > > CommitDate: 2021-04-29 12:33:56 +0000 > > > > > > Synch index of contrib/bc with what is in workdir after cloning. > > > > > > From a workdir perspective this should be a no-op. > > > See also: > > > https://lists.freebsd.org/pipermail/freebsd-current/2021-April/079569 > .htm > > > l > > > --- > > > contrib/bc/bc.vcxproj | 554 > > > ++++++++++++++++++++------------------- -- > > > contrib/bc/bc.vcxproj.filters | 362 +++++++++++++-------------- > > > contrib/bc/bcl.vcxproj | 320 ++++++++++++------------ > > > contrib/bc/bcl.vcxproj.filters | 190 +++++++------- > > > 4 files changed, 713 insertions(+), 713 deletions(-) > > > > > > > Whatever was done here I cannot rebase from main to my local > > branches. The files remain modified. The only recourse so far was to > > delete the local branch and start over. I've done this to one > > inconsequential branch so far but hopefully someone can suggest a > > solution. > > Can you show an example of how this fails for you (especially the error > messages)? slippy$ git pull -r --all Fetching freebsd remote: Enumerating objects: 9, done. remote: Counting objects: 100% (9/9), done. remote: Compressing objects: 100% (9/9), done. remote: Total 9 (delta 3), reused 0 (delta 0), pack-reused 0 Unpacking objects: 100% (9/9), 12.42 KiB | 111.00 KiB/s, done. >From https://git.freebsd.org/src 59b3b210a69e..d87ee7b97fe8 stable/13 -> freebsd/stable/13 Already up to date. slippy$ git co komquats Switched to branch 'komquats' slippy$ git st On branch komquats Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) modified: contrib/bc/bc.vcxproj modified: contrib/bc/bc.vcxproj.filters modified: contrib/bc/bcl.vcxproj modified: contrib/bc/bcl.vcxproj.filters Untracked files: (use "git add ..." to include in what will be committed) sys/i386/conf/IPFILTER usr.sbin/ufdformat/ no changes added to commit (use "git add" and/or "git commit -a") slippy$ git rebase main error: cannot rebase: You have unstaged changes. error: Please commit or stash them. slippy$ git stash push -m foobar Saved working directory and index state On komquats: foobar slippy$ git rebase main error: cannot rebase: You have unstaged changes. error: Please commit or stash them. slippy$ git st On branch komquats Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) modified: contrib/bc/bc.vcxproj modified: contrib/bc/bc.vcxproj.filters modified: contrib/bc/bcl.vcxproj modified: contrib/bc/bcl.vcxproj.filters Untracked files: (use "git add ..." to include in what will be committed) sys/i386/conf/IPFILTER usr.sbin/ufdformat/ no changes added to commit (use "git add" and/or "git commit -a") slippy$ git stash push -m foobar Saved working directory and index state On komquats: foobar slippy$ git st On branch komquats Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) modified: contrib/bc/bc.vcxproj modified: contrib/bc/bc.vcxproj.filters modified: contrib/bc/bcl.vcxproj modified: contrib/bc/bcl.vcxproj.filters Untracked files: (use "git add ..." to include in what will be committed) sys/i386/conf/IPFILTER usr.sbin/ufdformat/ no changes added to commit (use "git add" and/or "git commit -a") slippy$ rm the files, switch branch to main, rebase again, remove the branch, and start over was the only solution. So far this affected only one branch. My other branches are so far unaffected. As no other branch is affected it appears this was local to this one branch. The branch is (was) approximately four months old. Recreating it, which wasn't difficult, resolved the issue. This is the first time I've had any git problems of this nature here at FreeBSD. I've (we've) had many at $JOB because of git-lfs, causing similar looking issues. But that's a whole different kettle of fish. (I'm the only one at $JOB who uses git on a UNIX-like system while everyone else uses Visual Studio.) > > > > > git restore the files, git rm the files, rm the files, git stash > > push, all don't remove them from the branch following rebase. And > > subsequent rebase to main will fail. main is ok though. > > > > What is it that you did to sync the index? > > Like in the mail thread linked in the git comment, theoretically a noop: > > git clone https://git@repo.freebsd.org/src.git > cd src > touch contrib/bc/*vcx* > git commit -a > git push > > It's a problem caused by .gitattributes being checked in after the > *vcx* files were checked in (again, see the email thread and "man > 1 gitattributes"). > > If it was for me, I would remove the .gitattributes eol specs, they > shouldn't be necessary for our purposes. It's probably growing pains. It appears only one branch, probably not surprisingly my most used branch, was the only one affected. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.