From owner-svn-ports-all@freebsd.org  Thu Jun  2 15:07:24 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCAF4B64B81;
 Thu,  2 Jun 2016 15:07:24 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 345E9195C;
 Thu,  2 Jun 2016 15:07:23 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 080f2507
 TLS version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Thu, 2 Jun 2016 09:07:15 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: svn commit: r416270 - head/net/rsync
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201606020735.u527ZoAj066577@repo.freebsd.org>
Date: Thu, 2 Jun 2016 09:06:59 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: 7bit
Message-Id: <8D42CA4C-75EC-4402-BA69-DF20E3F62462@adamw.org>
References: <201606020735.u527ZoAj066577@repo.freebsd.org>
To: Emanuel Haupt <ehaupt@FreeBSD.org>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2016 15:07:24 -0000

> On 2 Jun, 2016, at 1:35, Emanuel Haupt <ehaupt@FreeBSD.org> wrote:
> 
> Author: ehaupt
> Date: Thu Jun  2 07:35:49 2016
> New Revision: 416270
> URL: https://svnweb.freebsd.org/changeset/ports/416270
> 
> Log:
>  Fix the logic of the POPT_PORT option.
> 
>  - POPT_CONFIGURE_WITH should actually be POPT_PORT_CONFIGURE_WITH
>  - The whole ^POPT block logic is reversing the logic
>  - Bump PORTREVISION since we have a change of dependencie
> 
>  PR:		209837 (based on)
>  Submitted by:	Martin Birgmeier <la5lbtyi@aon.at>
>  MFH:		2016Q2
> 
> -POPT_PORT_LIB_DEPENDS=	libpopt.so:devel/popt
> -POPT_PORT_CPPFLAGS=	-I${LOCALBASE}/include
> -POPT_PORT_LDFLAGS=	-L${LOCALBASE}/lib
> -POPT_CONFIGURE_WITH=	included-popt
> +POPT_PORT_LIB_DEPENDS_OFF=	libpopt.so:devel/popt
> +POPT_PORT_CPPFLAGS_OFF=	-I${LOCALBASE}/include
> +POPT_PORT_LDFLAGS_OFF=	-L${LOCALBASE}/lib
> +
> +POPT_PORT_CONFIGURE_WITH=	included-popt

Wait, now you've made it backwards.

Now:
"Use popt from devel/popt"
ON = use bundled popt
OFF = use popt from devel/popt

Those need to be switched!

# Adam


-- 
Adam Weinberger
adamw@adamw.org
http://www.adamw.org