From owner-freebsd-fs@FreeBSD.ORG Sat Mar 26 01:01:41 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 817931065673 for ; Sat, 26 Mar 2011 01:01:41 +0000 (UTC) (envelope-from giffunip@tutopia.com) Received: from nm5-vm1.bullet.mail.sp2.yahoo.com (nm5-vm1.bullet.mail.sp2.yahoo.com [98.139.91.205]) by mx1.freebsd.org (Postfix) with SMTP id 5D90A8FC22 for ; Sat, 26 Mar 2011 01:01:40 +0000 (UTC) Received: from [98.139.91.70] by nm5.bullet.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 01:01:40 -0000 Received: from [98.139.91.60] by tm10.bullet.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 01:01:40 -0000 Received: from [127.0.0.1] by omp1060.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 01:01:40 -0000 X-Yahoo-Newman-Property: ymail-5 X-Yahoo-Newman-Id: 898931.70738.bm@omp1060.mail.sp2.yahoo.com Received: (qmail 97842 invoked by uid 60001); 26 Mar 2011 01:01:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1301101299; bh=j/044l1Y7xedwX/bB2lfUh5/kcp4AU0tIOpeQ22umOU=; h=Message-ID:X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=l4cXPNswSQePRRTGU9mccHSy0BuMs4gAnpgGhA8wLVbYyEjs5j8uz7YKkBWRRSBagYHCFDOsef7ekqtYh0kMMreAwoU1X29UTTwoZJpzTJWD+kijGfItVo+GFk8bL5Qf1PqZsYg2RRCi1A4n9rn66NF1J+yhUo5Pua4wma0juG4= Message-ID: <650638.91967.qm@web113506.mail.gq1.yahoo.com> X-YMail-OSG: scMwYMwVM1kBgJHqc9VRQcT7M18ouhAYjd1Kc0lL.qf0wVf n.GpC.uQjPR2Y0vJeNEMhVBoxj21jnNUzYH7BD3uhVMrZARg_PxFmZ6xvo8N odMhAnJqs2arRLhsRJ9rjsAQDPh9EZ5dgRu_OR.mTqGrIQxpoVvnB6aYVFLL mpI3HK5fzJfxiQaCNobOW1T9.V4vGoXzkMfJZX8oqGV.kSqYwF_Sehbna8ty M2jEpL7aw6LPN_8CcOp.XHIpJ7sJOveDesroVETHTSMkrsxB6zdk4VvGIZKV HJ88AsN1igPanWhtSX5Deb3VpEzZBNIwdEVVa0HqGPQjkUgyxYk8.V.cOEfl Q6Aw6pZfhpBZOv3dLCkjgu.8RkSjyTaF8atH2_mRLiFJz6G35Z0D8Ocf0flq Q735JZoo3nQ_4 Received: from [200.118.159.55] by web113506.mail.gq1.yahoo.com via HTTP; Fri, 25 Mar 2011 18:01:39 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/12.0.2 YahooMailWebService/0.8.109.295617 Date: Fri, 25 Mar 2011 18:01:39 -0700 (PDT) From: "Pedro F. Giffuni" To: Kostik Belousov In-Reply-To: <20110325205654.GP78089@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: giffunip@tutopia.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2011 01:01:41 -0000 --- On Fri, 3/25/11, Kostik Belousov wrote: .... > No, I do not want it in our testing framework. I want to > see a standalone test that demonstrates the issue. > I think the leak is real, but want to have a way to > reproduce it before committing. > > The diff you pointed out to t_vnops.c does not make much > sense to me. I looked a little more in their records and I found this: _____ ... /* rename directory over an empty directory */ md(pb1, mp, "parent"); md(pb2, mp, "parent/dir1"); md(pb3, mp, "parent/dir2"); RL(rump_sys_mkdir(pb1, 0777)); RL(rump_sys_mkdir(pb2, 0777)); RL(rump_sys_mkdir(pb3, 0777)); RL(rump_sys_rename(pb2, pb3)); RL(rump_sys_stat(pb1, &sb)); ATF_CHECK_EQ(sb.st_nlink, 3); RL(rump_sys_rmdir(pb3)); if (FSTYPE_TMPFS(tc)) atf_tc_expect_signal(-1, "PR kern/44288"); ______ There's also this that was removed once the PR was fixed: - if (FSTYPE_MSDOS(tc)) - atf_tc_skip("test fails in some setups, reason unknown"); hope that helps. Pedro.