Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Nov 2022 22:31:22 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: bb9f61da17f6 - main - zfs: Remove devicename_stubs
Message-ID:  <202211302231.2AUMVMXr023534@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=bb9f61da17f66352a344e14c4d32fda83126827b

commit bb9f61da17f66352a344e14c4d32fda83126827b
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-11-30 22:09:18 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-11-30 22:30:32 +0000

    zfs: Remove devicename_stubs
    
    We no longer need the zfs stubs since we're no longer referencing these
    functions outside of zfs.c.
    
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D37345
---
 stand/i386/libi386/Makefile        |  5 -----
 stand/libofw/Makefile              |  4 ----
 stand/libsa/zfs/devicename_stubs.c | 40 --------------------------------------
 3 files changed, 49 deletions(-)

diff --git a/stand/i386/libi386/Makefile b/stand/i386/libi386/Makefile
index 1b23cd53d137..2b2cfd82812e 100644
--- a/stand/i386/libi386/Makefile
+++ b/stand/i386/libi386/Makefile
@@ -10,9 +10,6 @@ SRCS=	bio.c biosacpi.c biosdisk.c biosmem.c biospnp.c \
 	elf64_freebsd.c multiboot.c multiboot_tramp.S relocater_tramp.S \
 	i386_copy.c i386_module.c nullconsole.c pxe.c pxetramp.S \
 	time.c vidconsole.c vbe.c amd64_tramp.S spinconsole.c
-.PATH:	${ZFSSRC}
-SRCS+=  devicename_stubs.c
-CFLAGS+= -I${ZFSSRC}
 
 .PATH:	${SYSDIR}/teken
 SRCS+=	teken.c
@@ -44,8 +41,6 @@ CFLAGS+= -Dalloca=__builtin_alloca
 
 CFLAGS+=	-I${BOOTSRC}/ficl -I${BOOTSRC}/ficl/i386 \
 		-I${LDRSRC} -I${BOOTSRC}/i386/common \
-		-I${SYSDIR}/cddl/boot/zfs \
-		-I${SYSDIR}/cddl/contrib/opensolaris/uts/common \
 		-I${SYSDIR}/contrib/dev/acpica/include
 
 # Handle FreeBSD specific %b and %D printf format specifiers
diff --git a/stand/libofw/Makefile b/stand/libofw/Makefile
index 2d3e30e1ace9..0406224040e3 100644
--- a/stand/libofw/Makefile
+++ b/stand/libofw/Makefile
@@ -7,10 +7,6 @@ LIB=		ofw
 SRCS=	devicename.c ofw_console.c ofw_copy.c ofw_disk.c \
 	ofw_memory.c ofw_module.c ofw_net.c ofw_reboot.c \
 	ofw_time.c openfirm.c
-.PATH:	${ZFSSRC}
-SRCS+=  devicename_stubs.c
-CFLAGS+=	-I${ZFSSRC} -I${SYSDIR}/cddl/boot/zfs
-CFLAGS+=	-I${SYSDIR}/cddl/contrib/opensolaris/uts/common
 
 # Pick up the bootstrap header for some interface items
 CFLAGS+=	-I${LDRSRC}
diff --git a/stand/libsa/zfs/devicename_stubs.c b/stand/libsa/zfs/devicename_stubs.c
deleted file mode 100644
index 44df5251118a..000000000000
--- a/stand/libsa/zfs/devicename_stubs.c
+++ /dev/null
@@ -1,40 +0,0 @@
-/*-
- * Copyright (c) 2012 Andriy Gapon <avg@FreeBSD.org>
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
- */
-
-#include <sys/cdefs.h>
-__FBSDID("$FreeBSD$");
-
-#include <stand.h>
-#include "libzfs.h"
-
-__attribute__((weak))
-char *
-zfs_fmtdev(struct devdesc *vdev)
-{
-    static char	buf[128];
-
-    return (buf);
-}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202211302231.2AUMVMXr023534>