Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 09 Jul 2015 19:29:47 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 201414] [patch] x11-fm/pcmanfm: fix NLS option, sort USES
Message-ID:  <bug-201414-13-hvTUQnxGEE@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-201414-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-201414-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201414

--- Comment #9 from Andriy Voskoboinyk <s3erios@gmail.com> ---
(In reply to Horia Racoviceanu from comment #8)
> As koobs@ mentioned in comment 3 and the portlint warning, gettext should be 
> made conditional using an options helper.

gettext(-runtime) cannot be used conditionally, since devel/glib20 uses it.

For example

>   fm_show_error(NULL, NULL, _("Desktop manager is not active."));

will be converted into

>    fm_show_error(NULL, NULL, libintl_gettext("Desktop manager is not active."));

> Also, there is no need to add FLAGS here.

They're required for correct libintl.h detection:
> checking libintl.h usability... no
> checking libintl.h presence... no
> checking for libintl.h... no

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-201414-13-hvTUQnxGEE>