From owner-freebsd-ports-bugs@freebsd.org  Thu Jul  9 19:29:48 2015
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0CB49997E6F
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Thu,  9 Jul 2015 19:29:48 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EBFA51F40
 for <freebsd-ports-bugs@FreeBSD.org>; Thu,  9 Jul 2015 19:29:47 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t69JTlbV052575
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 9 Jul 2015 19:29:47 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 201414] [patch] x11-fm/pcmanfm: fix NLS option, sort USES
Date: Thu, 09 Jul 2015 19:29:47 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: needs-patch, patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: s3erios@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-201414-13-hvTUQnxGEE@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-201414-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-201414-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2015 19:29:48 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201414

--- Comment #9 from Andriy Voskoboinyk <s3erios@gmail.com> ---
(In reply to Horia Racoviceanu from comment #8)
> As koobs@ mentioned in comment 3 and the portlint warning, gettext should be 
> made conditional using an options helper.

gettext(-runtime) cannot be used conditionally, since devel/glib20 uses it.

For example

>   fm_show_error(NULL, NULL, _("Desktop manager is not active."));

will be converted into

>    fm_show_error(NULL, NULL, libintl_gettext("Desktop manager is not active."));

> Also, there is no need to add FLAGS here.

They're required for correct libintl.h detection:
> checking libintl.h usability... no
> checking libintl.h presence... no
> checking for libintl.h... no

-- 
You are receiving this mail because:
You are the assignee for the bug.