From owner-svn-src-head@freebsd.org Sat Oct 7 17:41:21 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9376BE3DA3D; Sat, 7 Oct 2017 17:41:21 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22c.google.com (mail-pf0-x22c.google.com [IPv6:2607:f8b0:400e:c00::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B79F6C52F; Sat, 7 Oct 2017 17:41:21 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22c.google.com with SMTP id z11so997694pfk.4; Sat, 07 Oct 2017 10:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=pTsk/Gvesi32od/13sZ3LndyBpXerq1K4SsgMOOr/zw=; b=BtUxxQ+3o7NesH9M5QAYpuCyFaiRdOOrd/EhIgcKXwYQGh19DIAKW9ASJOrnHYpxQP sKt/n964lvk+Cf0pKEdK7jxTUi7RVV4aLCRAICtYRJaAe8oNO/Vy4yk17j3aSYQ/ZxuO 74l+UVf6jU/ObIktd5YkJXi12gExWKiR2unVWziQSF6WwgKFeQrJo/ZY9fWP+AhRPhLE jdpFCpiqf39nK563VD4M5QuawyYYxJ0wF/6hbmxNHSoL1vTek4XBq0LEUdqflxECPuBO BQG05FMKKkJ4Fu+I38NaWgTEJIPQcys/hEh9G79s6zD1oOCW928JggUb9+AkXERbmGOi qEHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=pTsk/Gvesi32od/13sZ3LndyBpXerq1K4SsgMOOr/zw=; b=SacSZ6pFLlWjuoyqFjTDKBqDPasHWIfeJ3U/gbx4AjQO2jch6+18SNy05BwqHNNZpE jzFT1nnUx/kqTszK1YoakiWhGtda7e80WwaJtlw6AY7BgJsVQulnT/sZguWiIHMW8yJT 9NzVg+3sO8A4xktvg000JZd/B7fX3lz1OhzXXKnm13hwGc8crtlgg+kOHkPTLP0VXds5 a+LQxRRjfmdXpEx4vKSBwbKqkpoJWZhljMRugCFb1HV9rFfkuwQvK1/sQaXcUxRd9bdT rBEy6383TKRF9yJffFkIMV5z5K5zB9LA0+VyykgVRvoWQAo8tO+49pYDyoKHMF9+/mSg sndw== X-Gm-Message-State: AMCzsaUiqM5/dZLLJQaBk7pHF9y6VASUMAo73rm0dNLLrUxB4E52OBU5 1i6wExiOU5NDQFlIsLGscfHApCvr X-Google-Smtp-Source: AOwi7QDeMmruuo1+dySR2ofbjmTdknzEMOorT1ytWN2r50UQtbGn+rrvvYjhXg2Kg2qElkvXXC/wBQ== X-Received: by 10.159.198.72 with SMTP id y8mr5219789plt.410.1507398080755; Sat, 07 Oct 2017 10:41:20 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id v69sm9919789pfd.75.2017.10.07.10.41.19 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 07 Oct 2017 10:41:20 -0700 (PDT) Subject: Re: svn commit: r324360 - in head/sys/boot/efi: include libefi loader Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_AFF3218D-9CC1-4A03-B0EA-379ED74F0AFC"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Sat, 7 Oct 2017 10:41:18 -0700 Cc: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <4EAC495A-0CC8-4781-9F04-A5F1B7E293D4@gmail.com> References: <201710061221.v96CLko0046237@repo.freebsd.org> To: Guy Yur X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Oct 2017 17:41:21 -0000 --Apple-Mail=_AFF3218D-9CC1-4A03-B0EA-379ED74F0AFC Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On Oct 7, 2017, at 09:29, Guy Yur wrote: > > On 6 October 2017 at 15:21, Warner Losh wrote: >> Author: imp >> Date: Fri Oct 6 12:21:46 2017 >> New Revision: 324360 >> URL: https://svnweb.freebsd.org/changeset/base/324360 >> >> Log: >> Encapsulate ZFS preferences into efi_zfs_is_preferred >> >> Move the retrieval of the image information into loader's main instead >> of doing it in efizfs.c >> >> Differential Revision: https://reviews.freebsd.org/D12564 >> Submitted by: Eric McCorkle >> >> Modified: >> head/sys/boot/efi/include/efizfs.h >> head/sys/boot/efi/libefi/efizfs.c >> head/sys/boot/efi/loader/main.c >> >> ... > > Hi, > > When setting WITHOUT_ZFS in src.conf the build fails with: > > /usr/src/sys/boot/efi/loader/main.c:78:1: error: no previous prototype > for function 'efi_zfs_is_preferred' > [-Werror,-Wmissing-prototypes] > efi_zfs_is_preferred(EFI_HANDLE *h) > ^ > 1 error generated. > *** Error code 1 > > > The prototype is under #ifdef EFI_ZFS_BOOT guard but the function is not. Fixed: r324388. Thanks! -Ngie --Apple-Mail=_AFF3218D-9CC1-4A03-B0EA-379ED74F0AFC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZ2RG/AAoJEPWDqSZpMIYVPGIP/RCxIj8Ej1vsDW1lhORxOpiY a471gULrl9YYbxJqU5JtGonT0xuCbDYhTUVg2LIlkIOM85jwU3+9LpYR/z9zjcoG qZM9olbQhPMXcKX7UI/QFoiBbSqF9RGL1/+VRAW5yi1iEIcpfLK77lxJvxk8VlLX YKJjkpEmOGks6+W/Wm8P427Uqr9/73F+LBXTs63SU6Dy9RAtbBlBB2vjbplK+MYF Cogt92QeC9Lo10eMqbxdFG914BoJ0/LUruEx1jGx6REddOd0y0F6FDAJ3A98iBuk oAvLJ4aX1i6WN5fiou2O0Wn2UAZ+B7zBl/Rx3yaPov+EZD5oEClbAmf8BVX+ZTB4 Gu8UPpA05ONXLICwoMpAGqska846kxSf5eGvtP88QKD9sXY3QBh+2+xc9mH6k8fL 61ntVlZx3FnfiYySv8fekpT0BFl6Jzhl+D0D6G9lO1It1LuzTwnPS1WYG7tbLt/h YHyZQLSOsNg0CV91Ht5eupGFBSqOWihA3cOnhV/zF51DPSt2KEY+vPvlovub0N7s 6F8QKYHErkQjU/T04Y6/mzoEYjskWA2HEQIRb7SmP7PMLSLIxThZxMdAR9va3kdI /WZtNpYf6K5L4PeV7z/gFiULd9mQs+y5G8VqMS2ccgcIzKEcFNqdc9ewL8JF93Dw zew4Qy/evcqo0wVvm3Vr =EdHq -----END PGP SIGNATURE----- --Apple-Mail=_AFF3218D-9CC1-4A03-B0EA-379ED74F0AFC--