Date: Sat, 7 Oct 2017 10:41:18 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Guy Yur <guyyur@gmail.com> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324360 - in head/sys/boot/efi: include libefi loader Message-ID: <4EAC495A-0CC8-4781-9F04-A5F1B7E293D4@gmail.com> In-Reply-To: <CAC67Hz9oMO7q29U43ZJbjYTSfv-13yeNrBeuPscHP4oMFqWGLw@mail.gmail.com> References: <201710061221.v96CLko0046237@repo.freebsd.org> <CAC67Hz9oMO7q29U43ZJbjYTSfv-13yeNrBeuPscHP4oMFqWGLw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_AFF3218D-9CC1-4A03-B0EA-379ED74F0AFC Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On Oct 7, 2017, at 09:29, Guy Yur <guyyur@gmail.com> wrote: > > On 6 October 2017 at 15:21, Warner Losh <imp@freebsd.org> wrote: >> Author: imp >> Date: Fri Oct 6 12:21:46 2017 >> New Revision: 324360 >> URL: https://svnweb.freebsd.org/changeset/base/324360 >> >> Log: >> Encapsulate ZFS preferences into efi_zfs_is_preferred >> >> Move the retrieval of the image information into loader's main instead >> of doing it in efizfs.c >> >> Differential Revision: https://reviews.freebsd.org/D12564 >> Submitted by: Eric McCorkle >> >> Modified: >> head/sys/boot/efi/include/efizfs.h >> head/sys/boot/efi/libefi/efizfs.c >> head/sys/boot/efi/loader/main.c >> >> ... > > Hi, > > When setting WITHOUT_ZFS in src.conf the build fails with: > > /usr/src/sys/boot/efi/loader/main.c:78:1: error: no previous prototype > for function 'efi_zfs_is_preferred' > [-Werror,-Wmissing-prototypes] > efi_zfs_is_preferred(EFI_HANDLE *h) > ^ > 1 error generated. > *** Error code 1 > > > The prototype is under #ifdef EFI_ZFS_BOOT guard but the function is not. Fixed: r324388. Thanks! -Ngie --Apple-Mail=_AFF3218D-9CC1-4A03-B0EA-379ED74F0AFC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZ2RG/AAoJEPWDqSZpMIYVPGIP/RCxIj8Ej1vsDW1lhORxOpiY a471gULrl9YYbxJqU5JtGonT0xuCbDYhTUVg2LIlkIOM85jwU3+9LpYR/z9zjcoG qZM9olbQhPMXcKX7UI/QFoiBbSqF9RGL1/+VRAW5yi1iEIcpfLK77lxJvxk8VlLX YKJjkpEmOGks6+W/Wm8P427Uqr9/73F+LBXTs63SU6Dy9RAtbBlBB2vjbplK+MYF Cogt92QeC9Lo10eMqbxdFG914BoJ0/LUruEx1jGx6REddOd0y0F6FDAJ3A98iBuk oAvLJ4aX1i6WN5fiou2O0Wn2UAZ+B7zBl/Rx3yaPov+EZD5oEClbAmf8BVX+ZTB4 Gu8UPpA05ONXLICwoMpAGqska846kxSf5eGvtP88QKD9sXY3QBh+2+xc9mH6k8fL 61ntVlZx3FnfiYySv8fekpT0BFl6Jzhl+D0D6G9lO1It1LuzTwnPS1WYG7tbLt/h YHyZQLSOsNg0CV91Ht5eupGFBSqOWihA3cOnhV/zF51DPSt2KEY+vPvlovub0N7s 6F8QKYHErkQjU/T04Y6/mzoEYjskWA2HEQIRb7SmP7PMLSLIxThZxMdAR9va3kdI /WZtNpYf6K5L4PeV7z/gFiULd9mQs+y5G8VqMS2ccgcIzKEcFNqdc9ewL8JF93Dw zew4Qy/evcqo0wVvm3Vr =EdHq -----END PGP SIGNATURE----- --Apple-Mail=_AFF3218D-9CC1-4A03-B0EA-379ED74F0AFC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EAC495A-0CC8-4781-9F04-A5F1B7E293D4>