From owner-cvs-all@FreeBSD.ORG  Wed Jul 23 11:23:48 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 48CF837B407
	for <cvs-all@FreeBSD.org>; Wed, 23 Jul 2003 11:23:48 -0700 (PDT)
Received: from mail.speakeasy.net (mail7.speakeasy.net [216.254.0.207])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8E4B443FBF
	for <cvs-all@FreeBSD.org>; Wed, 23 Jul 2003 11:23:45 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 4157 invoked from network); 23 Jul 2003 18:23:45 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <src-committers@FreeBSD.org>; 23 Jul 2003 18:23:45 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6NINgGI046372;
	Wed, 23 Jul 2003 14:23:43 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030723142400.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200307231803.h6NI3NQS017696@repoman.freebsd.org>
Date: Wed, 23 Jul 2003 14:24:00 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Poul-Henning Kamp <phk@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: RE: cvs commit: src/sys/dev/rp rp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jul 2003 18:23:48 -0000


On 23-Jul-2003 Poul-Henning Kamp wrote:
> phk         2003/07/23 11:03:23 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/rp           rp.c 
>   Log:
>   Undo single-intance inlining which is way above the comfort limit for GCC.

Single instance inlining can not hurt.  It can help by reducing call
stack depth and code size however.  I thought you were for reducing code
size, not increasing it.  Please use __always_inline to shut up gcc
instead of de-inlining for single instance inlines.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/