From owner-cvs-all@FreeBSD.ORG Wed Oct 31 22:38:12 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 60A8016A418; Wed, 31 Oct 2007 22:38:12 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id CEB8A13C4AA; Wed, 31 Oct 2007 22:38:11 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9VMbRFi091089; Thu, 1 Nov 2007 01:37:27 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1193870247; bh=cKJiBK9XZlnFTOg37b9IKjXl+xO47cb6+tbtOgO Q3BQ=; l=577; h=Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:User-Agent; b=g6VtzOh31gFqPUddff2pPMq61/EFoVP8MWc9SBC/ IiTGtTO8VRt/rUv2B2xWFiiwpL6lnvu1iermMa8Rwo34DnUgXNAav0gJdt6OEqNJdkf YUugs21vavFqExzzkSXQHMm00QLyMKZBfUKIPe7mL6mNc8in1ExP06FwBSgoC1hw= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9VMbRRw091088; Thu, 1 Nov 2007 01:37:27 +0300 (MSK) (envelope-from ache) Date: Thu, 1 Nov 2007 01:37:27 +0300 From: Andrey Chernov To: Alexey Dokuchaev Message-ID: <20071031223727.GB90994@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alexey Dokuchaev , Juli Mallett , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200710272232.l9RMWSbK072082@repoman.freebsd.org> <20071030200331.GA29309@toxic.magnesium.net> <20071031215526.GC89932@nagual.pp.ru> <20071031223349.GA552@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071031223349.GA552@FreeBSD.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, Juli Mallett , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/include _ctype.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2007 22:38:12 -0000 On Wed, Oct 31, 2007 at 10:33:49PM +0000, Alexey Dokuchaev wrote: > > For ones who doubts there two tests compiled with -O2. As you may see the > > result is almost identical (andl vs cmpl): > > Q.E.D. How about to restore original, more reader-friendly version then? 1. Reader-friendly version generates long code when absolutely no optimization used in compiler (for some reason f.e. to avoid optimization bugs). 2. It also breaks common style ctype using for is{w}ascii(). If revert this, is{w}ascii() should be rewritted too. -- http://ache.pp.ru/