From owner-trustedbsd-cvs@FreeBSD.ORG  Sun Jan 21 22:33:07 2007
Return-Path: <owner-trustedbsd-cvs@FreeBSD.ORG>
X-Original-To: trustedbsd-cvs@freebsd.org
Delivered-To: trustedbsd-cvs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 873D316A400
	for <trustedbsd-cvs@freebsd.org>; Sun, 21 Jan 2007 22:33:07 +0000 (UTC)
	(envelope-from owner-perforce@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id BDE2913C461
	for <trustedbsd-cvs@freebsd.org>; Sun, 21 Jan 2007 22:33:04 +0000 (UTC)
	(envelope-from owner-perforce@freebsd.org)
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by cyrus.watson.org (Postfix) with ESMTP id E5858480B2
	for <trustedbsd-cvs@trustedbsd.org>;
	Sun, 21 Jan 2007 17:32:59 -0500 (EST)
Received: from hub.freebsd.org (hub.freebsd.org [69.147.83.54])
	by mx2.freebsd.org (Postfix) with ESMTP id E047292B8F;
	Sun, 21 Jan 2007 22:27:17 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D7A7C16A404; Sun, 21 Jan 2007 22:27:17 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9E36116A402
	for <perforce@freebsd.org>; Sun, 21 Jan 2007 22:27:17 +0000 (UTC)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 8CABD13C441
	for <perforce@freebsd.org>; Sun, 21 Jan 2007 22:27:17 +0000 (UTC)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0LMRHm5060496
	for <perforce@freebsd.org>; Sun, 21 Jan 2007 22:27:17 GMT
	(envelope-from millert@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0LMRHoY060493
	for perforce@freebsd.org; Sun, 21 Jan 2007 22:27:17 GMT
	(envelope-from millert@freebsd.org)
Date: Sun, 21 Jan 2007 22:27:17 GMT
Message-Id: <200701212227.l0LMRHoY060493@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	millert@freebsd.org using -f
From: Todd Miller <millert@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 113271 for review
X-BeenThere: trustedbsd-cvs@FreeBSD.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: TrustedBSD CVS and Perforce commit message list
	<trustedbsd-cvs.FreeBSD.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>, 
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/trustedbsd-cvs>
List-Post: <mailto:trustedbsd-cvs@FreeBSD.org>
List-Help: <mailto:trustedbsd-cvs-request@FreeBSD.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>,
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jan 2007 22:33:07 -0000

http://perforce.freebsd.org/chv.cgi?CH=113271

Change 113271 by millert@millert_macbook on 2007/01/21 22:27:14

	If a process fails a MAC permission check when waiting for
	a child, do not return the entrypoint error code directly.
	Instead, just return ECHILD if there are no processes it
	is permitted to wait for.

Affected files ...

.. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/bsd/kern/kern_exit.c#6 edit

Differences ...

==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/bsd/kern/kern_exit.c#6 (text+ko) ====

@@ -686,8 +686,15 @@
 			continue;
 
 #ifdef MAC
-		if ((error = mac_proc_check_wait(kauth_cred_get(), p)) != 0)
-			return (error);
+		/*
+		 * We can not return the MAC error back to userland as
+		 * the caller would get non-standard error code.
+		 * Instead, we will return ECHILD (see below) if there
+		 * are no processes we are permitted to wait on.
+		 */
+		error = mac_proc_check_wait(kauth_cred_get(), p);
+		if (error)
+			continue;
 #endif
 
 		nfound++;