From owner-cvs-all Thu Mar 7 15:16: 4 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 664) id 7787537B478; Thu, 7 Mar 2002 15:13:34 -0800 (PST) Date: Thu, 7 Mar 2002 15:13:33 -0800 From: David O'Brien To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/dd args.c dd.c dd.h Message-ID: <20020307151333.A72218@hub.freebsd.org> Reply-To: obrien@freebsd.org References: <20020307035232.A67494@hub.freebsd.org> <200203071216.g27CGMRV010209@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200203071216.g27CGMRV010209@grimreaper.grondar.org>; from mark@grondar.za on Thu, Mar 07, 2002 at 12:16:22PM +0000 X-Operating-System: FreeBSD 4.4-STABLE Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Mar 07, 2002 at 12:16:22PM +0000, Mark Murray wrote: > > You wanna see my warning-and-error-suppression list? > > Please do not assume that a) I am doing this mechanically, or b) that I > am anally "fixing" every warning that I see. I have looked closer at many of your WARNS/lint(1) fixes. A lot of them are very good. Your adding const in prototypes and to string vars, and changing some `int' definitions to `u_int' (I don't care about the spelling of unsigned int) are good. As is making more functions static. These changes are hard to have problems with. Is it possible to maybe commit WARNS/lint fixes in stages -- first the total no brainers, and later those that might have more controversy? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message