Date: Thu, 2 Nov 2000 07:51:45 -0800 (PST) From: <sobomax@FreeBSD.org> To: sjhports@tracking.amos.net, sobomax@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: ports/21811: New Port: editors/dte - simple text editor with MSDOS EDIT keybindings. Message-ID: <200011021551.HAA14954@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: New Port: editors/dte - simple text editor with MSDOS EDIT keybindings.
State-Changed-From-To: open->closed
State-Changed-By: sobomax
State-Changed-When: Thu Nov 2 07:44:06 PST 2000
State-Changed-Why:
Committed with several changes/cleanups:
- you don't have to strip installed binary if `-s' install(1) flags used
(${INSTALL_PROGRAM} includes it).
- mkstemp(3) function used improperly in your patch - unlike mktemp(3) it's not
only constructs filename for temporary file, but (and it's the difference
between those two functions) opens it and returns descriptor of this file.
Therefore you don't have to open this file again. RTFM.
- There is no gurantee that USER variable is set, therefore you can't just replace
cuserid(3) with getenv("USER").
I also made this port respecting global CFLAGS.
http://www.freebsd.org/cgi/query-pr.cgi?pr=21811
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200011021551.HAA14954>