Date: Wed, 23 May 2001 10:16:43 +1000 From: Benno Rice <benno@FreeBSD.org> To: Doug Rabson <dfr@nlsystems.com> Cc: freebsd-ppc@freebsd.org Subject: Re: FreeBSD/powerpc work to date Message-ID: <20010523101643.A70899@rafe.jeamland.net> In-Reply-To: <Pine.BSF.4.33.0105221534590.46007-100000@herring.nlsystems.com>; from dfr@nlsystems.com on Tue, May 22, 2001 at 04:15:12PM %2B0100 References: <20010521234812.B56326@rafe.jeamland.net> <Pine.BSF.4.33.0105221534590.46007-100000@herring.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 22, 2001 at 04:15:12PM +0100, Doug Rabson wrote: > On Mon, 21 May 2001, Benno Rice wrote: >=20 > > Please feel free to review, comment, etc. > > > > The snapshot is in the form of a diff against -CURRENT and a tar.gz file > > containing new files that would need to be committed. Both of these > > files are rooted in src/sys. >=20 > Nice! Reading through the changes, I have a couple of comments. In > mp_machdep.c, you should remove the 'include <machine/rpb.h>' - that is > only ever likely to exist on alpha. You can alsp delete ipl.h since that > has been removed for the other arches. Ah. I started with the code from NetBSD and pulled bits from around the tr= ee to fill gaps, so there's some weirdness in there. =3D) =20 > In swtch.s, you are correct in thinking that Idle is unneeded. A generic > assembler question - why the use of _C_LABEL(xx)? Surely since we are only > ever going to be using ELF here, we can assume the format of C names? Its > difficult to see what is happening since I'm not familiar with powerpc > assembler but it appears that you are saving the process state on the > stack (using a 'struct switchframe'). The other architectures save this > information in the PCB - I'm not sure which is the best place. This is probably NetBSD code. Since I haven't got that far yet, it's pretty much unchanged except that I separated their locore.s into smaller files as per the other FreeBSD ports. =20 > I notice that pmap.c contains a mix of programming styles with some of the > code using ANSI and some K&R. The trend seems to be to move to ANSI for > all new code so its probably worth converting the rest of the file. Yeah. I'll be doing that. =20 > How far does the beast get when booting? There's still an issue somewhere in the pmap code in that as soon as I flush the TLB it starts having problems. If I leave the TLB alone though it mana= ges to crawl it's way to vm_mem_init and vm_page_startup before falling over. --=20 Benno Rice benno@FreeBSD.org --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjsLAWoACgkQbQx7xhW+Eg5lJQCfUH2vge6LryvYkS9yn2kBiBx8 M7EAoMheaLYHCj8nYXJRoh2+NBQZj1/s =hLgh -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ppc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010523101643.A70899>