Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Nov 2000 01:15:02 -0500
From:      Garance A Drosihn <drosih@rpi.edu>
To:        Garance A Drosehn <gad@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/lpr/lpd printjob.c
Message-ID:  <p04330105b63536a9a3d7@[128.113.24.47]>
In-Reply-To: <200011130544.VAA16031@freefall.freebsd.org>
References:  <200011130544.VAA16031@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
At 9:44 PM -0800 11/12/00, I (Garance A Drosehn) wrote:
>gad         2000/11/12 21:44:50 PST
>
>   Modified files:
>     usr.sbin/lpr/lpd     printjob.c
>   Log:
>   Replace call to mktemp() with mkstemp.  Also move where that call is
>   done, so the correct directory is being checked.  The mkstemp() call
>   is meant to create a temp file for stderrs when running filters.  This
>   update also fixes log-file processing for remote (rm=) queues which
>   specify an input filter (if=).  Before, filter-errs were thrown away.
>   Now they'll be copied to the queue's logfile (lf=).

I should mention that in this specific case, the call to mktemp
was NOT a security exposure.  Still, it doesn't hurt to change
that to mkstemp while fixing other things, and it gets rid of
the warning message when linking lpd.

-- 

---
Garance Alistair Drosehn            =   gad@eclipse.acs.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p04330105b63536a9a3d7>