From owner-svn-src-all@freebsd.org Fri Jan 3 17:50:17 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABEC11F691E; Fri, 3 Jan 2020 17:50:17 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-xc29.google.com (mail-yw1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47qC9N3gHSz46Js; Fri, 3 Jan 2020 17:50:16 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-yw1-xc29.google.com with SMTP id b186so18843979ywc.1; Fri, 03 Jan 2020 09:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Am7rIcCl271IOuoM5jzfeQdc/I4Y1YZKOOrxnBeJSTs=; b=YzUD62OHMZVC3viMQ34/tDiKIbnUOPulCv+4qT+qtWcLzThxO/tzsdcsEwczMNzFF4 W3tw/dG/dgYUO9+EG+VX8eo5udjLVqPl4t0pMyT0bPUVIwIvCXI5DHDv1VdXZGEem/Dq RMFfOB58cLrjmrjSYyrBIdb+HXIUdOviEe3ecaeB6ijEJEmFS3PkOCUizmFbX/kZoDbf LxRrjL4TZAS5Wkdw1d2hSEmV0G/dZiX9iNVESQWTrdz5iagH5B4kZh7kTUFX1KjDUvI6 7f6lj1UxIYPm0bEZDaA+YErjHdLofYlmyrIGL+suQQ0013JCRgvFfP33VKHh7LUGSN5I jRPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Am7rIcCl271IOuoM5jzfeQdc/I4Y1YZKOOrxnBeJSTs=; b=iN4lVTRPIxRlj+HgpKzw9Rnmu7+uXa4/m8dZzLHEzBq2wTIQ2CdLYtIDuM8CAbuKA/ RTcgJB+W42YJLBfd66FGIkHDnb2nj70Yodrcs/zAdqYpJJ7+sT3cheBpw3dax9Y0B524 +ahQ6JwtIFYxPqi7yMvik5jdLt0hSqTDJlALdQwCq0FvMcrjtzeW8uz26a2S/XWq2TyR Up3l2fxUJM2geB5LOggMvGt6y042diS8lg18KH8LnBAirPFqdO5TE50uLC6Yiyf38OT3 49rKXE+JcXI1vEZJYkbui+zpQRthStB121m7iD3SFLtskc5i3QUoI8crCAthOIGo1GPb zzeA== X-Gm-Message-State: APjAAAUhxhGFPF98MrJkwiNyvXdqjmuzwUhdCCd2Ayb+qcrwWpwCCRNr 0VJIRsM8389rd6OLq8BKXHtuXX3U X-Google-Smtp-Source: APXvYqzvuQLC3TwhocLaNITWRAk/t7VMPavFM4yDpFD1w9m0FV9Oh3vwSXS9J7W2+oBUqs/14TTabw== X-Received: by 2002:a0d:eb88:: with SMTP id u130mr67197964ywe.326.1578073815046; Fri, 03 Jan 2020 09:50:15 -0800 (PST) Received: from mavoffice.ixsystems.com ([12.189.233.129]) by smtp.gmail.com with ESMTPSA id q185sm23971169ywh.61.2020.01.03.09.50.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jan 2020 09:50:14 -0800 (PST) Sender: Alexander Motin Subject: Re: svn commit: r356108 - head/sys/geom/vinum To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201912270136.xBR1aruf065831@repo.freebsd.org> <20200103172634.GI91104@spindle.one-eyed-alien.net> From: Alexander Motin Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAG0IUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raS5AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczM AAoJEIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLq A6xe6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHu uC5vgPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15Gc sS9YcQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9 TevwGsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCg lz65AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6ZAXgD tmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8FlvmI/c 40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt3ytU 8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZR1Ed EIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm59R8A EQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczMAAoJ EIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLqA6xe 6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHuuC5v gPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15GcsS9Y cQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9Tevw Gsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCglz4= Message-ID: Date: Fri, 3 Jan 2020 12:50:09 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200103172634.GI91104@spindle.one-eyed-alien.net> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 47qC9N3gHSz46Js X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=YzUD62OH; dmarc=none; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::c29 as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-4.86 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.66)[ip: (-9.23), ipnet: 2607:f8b0::/32(-2.14), asn: 15169(-1.86), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[9.2.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 17:50:17 -0000 On 03.01.2020 12:26, Brooks Davis wrote: > On Fri, Dec 27, 2019 at 01:36:53AM +0000, Alexander Motin wrote: >> Author: mav >> Date: Fri Dec 27 01:36:53 2019 >> New Revision: 356108 >> URL: https://svnweb.freebsd.org/changeset/base/356108 >> >> Log: >> Reimplement gvinum orphanization. >> >> gvinum was the only GEOM class, using consumer nstart/nend fields. Making >> it do its own accounting for orphanization purposes allows in perspective >> to remove burden of that expensive for SMP accounting from GEOM. >> >> Also the previous implementation spinned in a tight event loop, waiting >> for all active BIOs to complete, while the new one knows exactly when it >> is possible to close the consumer. > > Do you know if there are other cases of gvinum being a weird GEOM class? > If it's going to require more rounds of major refactoring, maybe we > should look into deprecating it for 14. I've never used it myself, so may not know all of its issues. From what I briefly saw I have no other major objections about its code quality, other than it probably being not very fast, considering it is single-threaded and does not support unmapped I/O. It does not support resize, but not sure it is a big issue for its use case. But mostly the same, just a bit lighter, I can say about graid too, so gvinum does not look particularly bad for me, other than unlike graid I don't have any specific use case for it. -- Alexander Motin