From owner-cvs-all Thu Jul 26 13:54: 8 2001 Delivered-To: cvs-all@freebsd.org Received: from technokratis.com (modemcable052.174-202-24.mtl.mc.videotron.ca [24.202.174.52]) by hub.freebsd.org (Postfix) with ESMTP id 48B0A37B40A; Thu, 26 Jul 2001 13:53:57 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by technokratis.com (8.11.3/8.11.3) id f6QKvhr35181; Thu, 26 Jul 2001 16:57:43 -0400 (EDT) (envelope-from bmilekic) Date: Thu, 26 Jul 2001 16:57:43 -0400 From: Bosko Milekic To: Alfred Perlstein Cc: Bosko Milekic , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, mjacob@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha mp_machdep.c src/sys/i386/i386 mp_machdep.c src/sys/ia64/ia64 mp_machdep.c src/sys/kern subr_mbuf.c src/sys/powerpc/powerpc mp_machdep.c src/sys/sys mbuf.h src/usr.bin/netstat mbuf.c src/usr.bin/systat mbufs.c Message-ID: <20010726165743.A35171@technokratis.com> References: <200107261847.f6QIllE07093@freefall.freebsd.org> <20010726154741.I26571@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010726154741.I26571@elvis.mu.org>; from bright@mu.org on Thu, Jul 26, 2001 at 03:47:41PM -0500 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Jul 26, 2001 at 03:47:41PM -0500, Alfred Perlstein wrote: > * Bosko Milekic [010726 13:47] wrote: > > bmilekic 2001/07/26 11:47:47 PDT > > > > Modified files: > > sys/alpha/alpha mp_machdep.c > > sys/i386/i386 mp_machdep.c > > sys/ia64/ia64 mp_machdep.c > > sys/kern subr_mbuf.c > > sys/powerpc/powerpc mp_machdep.c > > sys/sys mbuf.h > > usr.bin/netstat mbuf.c > > usr.bin/systat mbufs.c > > Log: > > - Do not handle the per-CPU containers in mbuf code as though the cpuids > > were indices in a dense array. The cpuids are a sparse set and treat > > them as such, setting up containers only for CPUs activated during > > mb_init(). > > > > - Fix netstat(1) and systat(1) to treat the per-CPU stats area as a sparse > > map, in accordance with the above. > > > > This allows us to properly boot with certain CPUs disactivated. However, if > > we later decide to re-activate said CPUs, we will barf until we decide to > > implement CPU spinon/spinoff callback hooks to allow for said CPUs' per-CPU > > containers to get configured on their activation. > > > > Reported by: mjacob > > Partially (sys/ diffs) Submitted by: mjacob > > Yay for making the mbuf subsystem the only thing that can do per-cpu > pools! > > Can you guys please export this stuff so that other subsystems can > use it? Have you glanced at the committed code? the all_cpus stuff can actually be used by any code, not just the mbuf code. Everything else this delta includes are really mbuf subsystem-specific changes, which cannot be exported. What would be neat now is if someone took it upon themselves to actually implement the callback hooks so that any subsystem can use them. > thanks, > -- > -Alfred Perlstein [alfred@freebsd.org] > Ok, who wrote this damn function called '??'? > And why do my programs keep crashing in it? -- Bosko Milekic bmilekic@technokratis.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message