Date: Fri, 13 Sep 2013 02:24:02 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: gaod@hychen.org, portmgr@freebsd.org Subject: ports/182054: [PATCH] dns/libidn: Amend to pkg-config data, to fix FreeBSD 10-CURRENT build failure Message-ID: <E1VKHB4-000GNm-Me@apollo.emma.line.org> Resent-Message-ID: <201309130030.r8D0U0xb018215@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 182054
>Category: ports
>Synopsis: [PATCH] dns/libidn: Amend to pkg-config data, to fix FreeBSD 10-CURRENT build failure
>Confidential: no
>Severity: critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Sep 13 00:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Matthias Andree
>Release: FreeBSD 9.1-RELEASE-p6 amd64
>Organization:
>Environment:
System: FreeBSD apollo.emma.line.org 9.1-RELEASE-p6 FreeBSD 9.1-RELEASE-p6 #0: Wed Aug 21 20:40:52 UTC 2013
>Description:
FreeBSD 10 requires that all shared library symbols are resolved at link
time. This fails if a libidn user does not link against libintl, but
libidn itself is linked against libintl.
In this situation, pkg-config --libs must print -lintl after -lidn.
I have reported this to the help-libidn mailing list.
This patch fixes the bug, and bumps the portrevision (which is required
in this situation - we change installed files).
Port maintainer (gaod@hychen.org) is cc'd.
Gaod, please follow up with a message stating whether you approve of
this change or not.
Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:
--- libidn-1.28_1.patch begins here ---
diff -ruN /usr/ports/dns/libidn/Makefile ./Makefile
--- /usr/ports/dns/libidn/Makefile 2013-09-08 20:32:38.000000000 +0200
+++ ./Makefile 2013-09-13 02:02:42.000000000 +0200
@@ -1,8 +1,9 @@
# Created by: Kirill Ponomarew <ponomarew@oberon.net>
-# $FreeBSD: dns/libidn/Makefile 326767 2013-09-08 18:32:38Z sunpoet $
+# $FreeBSD: head/dns/libidn/Makefile 326767 2013-09-08 18:32:38Z sunpoet $
PORTNAME= libidn
PORTVERSION= 1.28
+PORTREVISION= 1
CATEGORIES= dns
MASTER_SITES= GNU
@@ -39,6 +40,9 @@
@${REINPLACE_CMD} -e '/^install-data-am: / s| install-imagesDATA||' \
${WRKSRC}/doc/Makefile.in
.endif
+.if ${PORT_OPTIONS:MNLS}
+ @${REINPLACE_CMD} -e 's/-lidn/& -lintl/' ${WRKSRC}/libidn.pc.in
+.endif
post-install:
.if ${PORT_OPTIONS:MDOCS}
--- libidn-1.28_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1VKHB4-000GNm-Me>