From owner-svn-src-all@FreeBSD.ORG  Tue Jan 20 14:23:00 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A693D276;
 Tue, 20 Jan 2015 14:23:00 +0000 (UTC)
Received: from mail-qg0-x233.google.com (mail-qg0-x233.google.com
 [IPv6:2607:f8b0:400d:c04::233])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5B3D375B;
 Tue, 20 Jan 2015 14:23:00 +0000 (UTC)
Received: by mail-qg0-f51.google.com with SMTP id z107so8026204qgd.10;
 Tue, 20 Jan 2015 06:22:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=lfr3EybwKOYWDbx+x7IcH1zlf3Dcy+kRKgbQhGwerME=;
 b=UUcOLAY9MhHeWjOxMoZ/ucf/PxVv1w+Yo+4jqh+qdV7B30Nd6wEurNVVJGF4GYSBLb
 HsRTslhc8ogTfKwbYVtgaZSv9bQRUtX0ubS9JNUjF2VEha6EaErZnRgqj/6Cszjq2Q00
 qme1KZBCVcVbKjo2bh0rXsZXKKIqmbhEOtewQID9RvtKQxrkKHAtzfyNt0sWJ2wbrAal
 Jkrb5SGpBg9H+HHfB3ePFLTkVFl2aDZcjDB2yjbEuKjQjTLE5ymSytBgeo9x/Kxcl1mw
 gyCgxMPO3vQS+S/Nc+PajtJKsTgXKv9TWLtVH7/VFl1ETAdplJ9GjhwMGKmp6kWsxn/o
 AGwg==
X-Received: by 10.140.37.39 with SMTP id q36mr43991733qgq.89.1421763779603;
 Tue, 20 Jan 2015 06:22:59 -0800 (PST)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.140.38.100 with HTTP; Tue, 20 Jan 2015 06:22:38 -0800 (PST)
In-Reply-To: <54B80CB6.5030102@FreeBSD.org>
References: <201501151532.t0FFWV2Y037455@svn.freebsd.org>
 <54B7E287.80406@FreeBSD.org>
 <54B7E566.8050601@selasky.org> <20150115171430.GO15484@FreeBSD.org>
 <20150115171539.GP15484@FreeBSD.org> <54B80CB6.5030102@FreeBSD.org>
From: Ed Maste <emaste@freebsd.org>
Date: Tue, 20 Jan 2015 09:22:38 -0500
X-Google-Sender-Auth: 8TQitBMbn65T3dShiwazSdjQNfw
Message-ID: <CAPyFy2BmKRZMnS7srQBF3Z6GKbGx8iDSf=GcS3U+LjjPvuPbbA@mail.gmail.com>
Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern
 sys/ofed/include/linux sys/sys
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: Hans Petter Selasky <hps@selasky.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 Sean Bruno <sbruno@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2015 14:23:00 -0000

On 15 January 2015 at 13:53, John Baldwin <jhb@freebsd.org> wrote:
>
> I think it's been a
> clear practice with all other changes reviewed in phabric to date that
> the committer only lists people in 'Reviewed by' who actually signed off
> on the patch, not just the list of people asked to review it.

This point is worth repeating. Phabricator is an add-on tool to aid in
pre-commit review, but is not a required part of our process and
doesn't change the meaning of commit message metadata fields.

"Reviewed by" in a commit message means exactly what it always has:
that those listed have reasonably carefully reviewed the change and
are willing to put their name on it.