Date: Sun, 23 Aug 2015 15:31:48 +0200 From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: Dmitry Sivachenko <trtrmitya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286329 - in head/etc: defaults rc.d Message-ID: <20150823133148.GB9866@brick.home> In-Reply-To: <92FC24C2-8B61-4B02-87E0-D4C6D4DA8ECF@gmail.com> References: <201508051738.t75Hc2MP038354@repo.freebsd.org> <92FC24C2-8B61-4B02-87E0-D4C6D4DA8ECF@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 0806T1152, Dmitry Sivachenko wrote: > > > On 5 авг. 2015 г., at 20:38, Edward Tomasz Napierala <trasz@FreeBSD.org> wrote: > > > > Author: trasz > > Date: Wed Aug 5 17:38:02 2015 > > New Revision: 286329 > > URL: https://svnweb.freebsd.org/changeset/base/286329 > > > > Log: > > Make rctl_enable rc variable actually work. To avoid breaking existing > > setups that worked before, flip the default to "YES". Most people don't > > have /etc/rctl.conf, so they won't be affected in any way. > > > > MFC after: 1 month > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/etc/defaults/rc.conf > > head/etc/rc.d/rctl > > > > Modified: head/etc/defaults/rc.conf > > ============================================================================== > > --- head/etc/defaults/rc.conf Wed Aug 5 17:21:42 2015 (r286328) > > +++ head/etc/defaults/rc.conf Wed Aug 5 17:38:02 2015 (r286329) > > @@ -664,7 +664,7 @@ opensm_enable="NO" # Opensm(8) for infin > > casperd_enable="YES" # casperd(8) daemon > > > > # rctl(8) requires kernel options RACCT and RCTL > > -rctl_enable="NO" # Load rctl(8) rules on boot > > +rctl_enable="YES" # Load rctl(8) rules on boot > > > Sad to see that rarely used feature has default as "YES". Requiring users to enable it in rc.conf would break existing setups, but it's also that it doesn't make much sense, IMHO. The etc/rc.d/rctl script was modeled after etc/rc.d/sysctl, and sysctl doesn't have the enable knob either. > PS: Please adjust rc.conf(5) accordingly, it assumes the default is NO. Done.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150823133148.GB9866>