From owner-svn-src-head@freebsd.org Sat Aug 12 21:53:51 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20346DCADC5; Sat, 12 Aug 2017 21:53:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22d.google.com (mail-pf0-x22d.google.com [IPv6:2607:f8b0:400e:c00::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DD8C972C9E; Sat, 12 Aug 2017 21:53:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22d.google.com with SMTP id t86so28368647pfe.2; Sat, 12 Aug 2017 14:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=NRQz+pdrR2nC+04oKItrsJkhPkbfg/9wCT0PM8O0Zns=; b=apN5AiHpk8WTYIt3qa/cVH4VywRlx6OtU6+k2C/Uc9taW2yiq6ai1BgmBcINbqZ22B WuL+4QWn3zfXcq2beTm+i+YD9s2B984CfssnX2HGe+zUDvhpsaCCtDCL0uxQYHpwtr82 6PzYFzH7JeKrTXPkaRR74vzuhn5v/jjH5oG5RtHe7OvwbBijEXfed9Klf8e+CwxUYQ7B 2B3L/3P/k5X2FJBw28+rrRZ0Xyg7yOJx5C5zTTXHdL235V70OzFXzImXmZU8ERJ8oxcq KKDU+ojtFx5J//yu+auM2WzY7cnVJJ5apAxWNtciYWnTLzA/+e1rXUl6b3MqjLAKoTNS v7xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=NRQz+pdrR2nC+04oKItrsJkhPkbfg/9wCT0PM8O0Zns=; b=HdNyy6/fwCmzrqLcqxSna7h7BNsTA/V/Y5sZC8GPvTN3gEkcAcqNEwFMYUo9OdJdDY ZRhcqFKwZDHIhqNXLusKdLmjUva2JJQGrQnTFROdQ0FvnvMW6np82zW7ThlcyFkniA8F 3xBodIjgO6BtB2yTdNQATTmrivxUuAhQe7gVriNCgoDtaqKyZAgXIMje/rZSrQDcXPHt iF03cmOE4hkJxgu+f9pFbREoWfcLpbFpY2yCUuXtXrf3bv/vwezRWjbIUxhiFK4iMinR oxuSY4m0KB7F6gAEgwfBpPym3Kcd/OvxkRs1DsKbPq0DbyTjV5ef2LLdcOEtj/6NEzFx mkNg== X-Gm-Message-State: AHYfb5hGfBiNjSJaEYctSJghmWDhtnva7KdSgvb+meNBANDCAT7LI7mx 8u5bxWNTzZKKFg2HCx0= X-Received: by 10.84.229.12 with SMTP id b12mr17966024plk.325.1502574830111; Sat, 12 Aug 2017 14:53:50 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id t5sm7313432pfd.96.2017.08.12.14.53.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 12 Aug 2017 14:53:49 -0700 (PDT) Subject: Re: svn commit: r322418 - head/lib/msun/src Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_BDF55496-57E5-4C13-8DF1-81D59F02CDC5"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <5672BE7A-0640-4C8B-9B41-44AD83D7B59E@gmail.com> Date: Sat, 12 Aug 2017 14:53:48 -0700 Cc: Ian Lepore , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Bruce Evans Message-Id: References: <201708112241.v7BMfP5X028262@repo.freebsd.org> <1502555191.47886.30.camel@freebsd.org> <5672BE7A-0640-4C8B-9B41-44AD83D7B59E@gmail.com> To: Ryan Libby X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2017 21:53:51 -0000 --Apple-Mail=_BDF55496-57E5-4C13-8DF1-81D59F02CDC5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 12, 2017, at 14:45, Ngie Cooper (yaneurabeya) = wrote: >=20 >>=20 >> On Aug 12, 2017, at 10:55, Ryan Libby wrote: >=20 > =E2=80=A6 >=20 >> A few possible quick fixes: >>=20 >> - Change the {arm64,riscv,sparc64}/include/float.h LDBL_MAX_EXP >> definitions from (+16384) to 16384. >>=20 >> - Change HALF_LDBL_MAX from >> #define HALF_LDBL_MAX __CONCAT(__CONCAT(0x0.8p, LDBL_MAX_EXP), L) >> to >> #if LDBL_MAX_EXP !=3D 0x4000 >> #error "Unsupported long double format" >> #endif >> #define HALF_LDBL_MAX 0x0.8p16384L >>=20 >> - Change the HALF_LDBL_MAX constant to a variable constructed with >> LD80C(), I think with >> LD80C(0x8000000000000000, 16383, 5.9486574767861588254e+4931L) >> but this also requires #error for LDBL_MAX_EXP !=3D 0x4000, so not >> really any better than the above. >>=20 >> I think I will back the patch out for now and go back to review. >=20 > The issue is an inconsistency with how LDBL_MAX_EXP is defined in the = MD headers: * is an -> is due to an > $ grep -r LDBL_MAX_EXP sys/sparc64/ > sys/sparc64/include/float.h:#define LDBL_MAX_EXP (+16384) > $ grep -r LDBL_MAX_EXP sys/x86/ > sys/x86/include/float.h:#define LDBL_MAX_EXP 16384 Here are the full gamut of definitions for LDBL_MAX_EXP. It = seems that sparc64 isn=E2=80=99t the only architecture using this = pattern: $ grep -r DBL_MAX_EXP sys/*/include sys/arm/include/float.h:#define DBL_MAX_EXP 1024 sys/arm/include/float.h:#define LDBL_MAX_EXP DBL_MAX_EXP sys/arm64/include/float.h:#define DBL_MAX_EXP 1024 sys/arm64/include/float.h:#define LDBL_MAX_EXP (+16384) sys/mips/include/float.h:#define DBL_MAX_EXP 1024 sys/mips/include/float.h:#define LDBL_MAX_EXP DBL_MAX_EXP sys/powerpc/include/float.h:#define DBL_MAX_EXP 1024 sys/powerpc/include/float.h:#define LDBL_MAX_EXP DBL_MAX_EXP sys/riscv/include/float.h:#define DBL_MAX_EXP 1024 sys/riscv/include/float.h:#define LDBL_MAX_EXP (+16384) sys/sparc64/include/float.h:#define DBL_MAX_EXP 1024 sys/sparc64/include/float.h:#define LDBL_MAX_EXP (+16384) sys/x86/include/float.h:#define DBL_MAX_EXP 1024 sys/x86/include/float.h:#define LDBL_MAX_EXP 16384 It might also be an inconsistency with how clang vs gcc [4.2.1] = handles __CONCAT, and what -std=3D flags are passed to ${CC} in the = Makefile, since the implementation is predicated by whether or not = it=E2=80=99s C++ or __STDC__ is defined. There might be an update that = we can grab from NetBSD (since the macro originated there). I don=E2=80=99t understand [right now] why the (+foo) form is = used *shrugs*. Cheers, -Ngie --Apple-Mail=_BDF55496-57E5-4C13-8DF1-81D59F02CDC5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZj3jsAAoJEPWDqSZpMIYVuNIP/A2L0Q2+TY9QRBVFTFofoDJF PGjMe3E87pDLGuCePk0W3IBo6raGJ1tQw8WhYJast4H/z38J5VImuF0er//ZzUTf E76rB44simjn9tsM38lTNGFmBWKgvbrXJxTVFyEEE3tGL7rWW3sG0tf44HW3Z3tk cR/+8lO6RkFV3RodrPS1VhNFgV6WvzAgyyO4oYcx176HBdY/qlzXeFbww2swfgnZ rLTmmUQD4wLgfSSxkBCoKdru/YOGpCNeqQg1Dy7WDVBsMs2m7UL3RO0olgtdE0kr DDc2FCuUcDM2DpQBvG9PoRm3maK/OfVUgK16cc4np7mAg2cn4kERuSJMmE7PJFdS FOKcfBi+ACZJXFWkEGfEoUeW8QDjiBUC8sLfmuPQgjgYhyn9zsYhMj2bI6/W9L28 wzECELQl+F5yFxKg1QGRod/5BwqjLITTJSXMWGpuSE2tNMWiRxTpB/tjCofkbqES WhizL2QiZVdKZJLnUJAHW5IS4rAYdE4fZ3Y4rBwp3+TvZcDm+Y9z0XTIc6giUQfB kQkAxKRyz9wsW4Mw5wnb+RPiCSFpc4ptAD5OIQBY9UAJr9i7iT65IsBXZzDwobPj aygOzSs8hgQKQvJ5i+cUm80gcrKNIJRzR6LAMwhokrN+eFuTuPgp+JqIeUIKlFRa qrr+NeAAd4dM93ur8m4u =43lZ -----END PGP SIGNATURE----- --Apple-Mail=_BDF55496-57E5-4C13-8DF1-81D59F02CDC5--