From owner-freebsd-mips@FreeBSD.ORG Mon May 17 15:38:15 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E6E51065673; Mon, 17 May 2010 15:38:15 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-pz0-f181.google.com (mail-pz0-f181.google.com [209.85.222.181]) by mx1.freebsd.org (Postfix) with ESMTP id 4D4DF8FC19; Mon, 17 May 2010 15:38:15 +0000 (UTC) Received: by pzk11 with SMTP id 11so3540324pzk.28 for ; Mon, 17 May 2010 08:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=TzjoBKCGQU1Bf58z1hudotgoHcSpKv0gfI4KclesfsM=; b=XpZ/RoG/xXdNnKWI95fbGAPVu20mollgyP6LywuHOdSrunU1SPfAbR++7ZM8aFRC/L p1wsaGHP8/dbFmo6tz4H/or9O/IPEOey1pQ2B42JkD8iX2jedbtc8MG0n0+Ot7WY3lZs J1MQ5QwLtAUyTl/f9zIUwugcM9c/FGuwjmJ1M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=cVceabLQSZwpzPGGKsaD+sN9igNJC6hIF7/sURNSOIJ+ZHJmJj6+woIQFRxOrdOtym 3x4yaql56tlEJUMt8szroQDYfVTai+HXYtTW/AYCXFI2hI+U3IZ6ElOhyaIkRPPEiuye exsiz3miKUtb6AlWdsWd3xFrrVTmBZ8+QQJK4= MIME-Version: 1.0 Received: by 10.143.27.8 with SMTP id e8mr3520698wfj.332.1274110694648; Mon, 17 May 2010 08:38:14 -0700 (PDT) Received: by 10.142.172.9 with HTTP; Mon, 17 May 2010 08:38:14 -0700 (PDT) In-Reply-To: References: Date: Mon, 17 May 2010 08:38:14 -0700 Message-ID: From: Neel Natu To: "C. Jayachandran" Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-mips@freebsd.org Subject: Re: Minor fixup for the MIPS SMP platform code. X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 15:38:15 -0000 Hi JC, Your patch looks good. Thanks for cleaning up the platform-specific code from mp_machdep.c. There are a couple of style things you might want to take care of: 1. In hwfunc.h there is an extra space after the '*' in the declaration of platform_smp_topo() 2. In platform_smp_topo() for XLR: - Values in return statements should be enclosed in parantheses. - space around binary operator '/' best Neel On Mon, May 17, 2010 at 7:33 AM, C. Jayachandran wrote: > The attached patch (also at > http://sites.google.com/site/cjayachandran/files) has two changes: > - moves the intr masking code to platform_init_ap, so that we can avoid the > #ifdef for XLR > - adds a platform_smp_topo() function so that platforms can define their > topology > > I've also attempted to fixup sys/mips/sibyte to reflect these changes, but > it might need further work. > sys/mips/cavium also might need similar changes for SMP. > > Please review and apply if the changes are okay. > > Thanks, > JC. > >