From owner-freebsd-current@FreeBSD.ORG Tue Aug 7 14:11:08 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 655541065670; Tue, 7 Aug 2012 14:11:08 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost1.sentex.ca (smarthost1-6.sentex.ca [IPv6:2607:f3e0:0:1::12]) by mx1.freebsd.org (Postfix) with ESMTP id 255E38FC08; Tue, 7 Aug 2012 14:11:08 +0000 (UTC) Received: from [192.168.43.26] (pyroxene.sentex.ca [199.212.134.18]) by smarthost1.sentex.ca (8.14.5/8.14.5) with ESMTP id q77EB7ak021636; Tue, 7 Aug 2012 10:11:07 -0400 (EDT) (envelope-from mike@sentex.net) Message-ID: <502121F5.4020705@sentex.net> Date: Tue, 07 Aug 2012 10:11:01 -0400 From: Mike Tancsa Organization: Sentex Communications User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: John Baldwin References: <201208031418.57941.jhb@freebsd.org> <501C37D3.5040704@sentex.net> <9C0F7DB1-E75B-42A9-90A4-22599F99E15E@gmail.com> <201208031726.03652.jhb@freebsd.org> In-Reply-To: <201208031726.03652.jhb@freebsd.org> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.72 on 64.7.153.18 Cc: Garrett Cooper , current@freebsd.org Subject: Re: [PATCH] Add locking to twe(4) so it no longer uses Giant X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2012 14:11:08 -0000 On 8/3/2012 5:26 PM, John Baldwin wrote: >> If there's a tool for poking at the drives/controller, I would use that, plus camcontrol. Of course you want a data intensive workload > (iometer/iozone/xdd with async and sync mode, random reads and sequential reads, etc), and maybe resort to manual testing like pulling drives > (power, data) if you don't mind creating failures. If you have some failed/failing drives kicking around, that would be a good test as well (see > that all/some of the failure paths are properly stimulated). > > 3dm2 testing would be good for the ioctl handling, but the most critical > tests are basic I/O. > Looks like it breaks 3dm2 and the tw_cli. With the patch, I am not able to see the 8006 controller I added. tw_cli without the patch 0{offsite2}# tw_cli //offsite2> /c0 show Unit UnitType Status %RCmpl %V/I/M Stripe Size(GB) Cache AVrfy ------------------------------------------------------------------------------ u0 RAID-0 OK - - 64K 931.521 ON - Port Status Unit Size Blocks Serial --------------------------------------------------------------- p0 OK u0 465.76 GB 976773168 WD-WCAYUEY18298 p1 OK u0 465.76 GB 976773168 WD-WMAYUL256317 //offsite2> //offsite2> show Ctl Model (V)Ports Drives Units NotOpt RRate VRate BBU ------------------------------------------------------------------------ c0 8006-2LP 2 2 1 0 3 - - c1 9650SE-2LP 2 2 1 0 1 1 - The boot array is c1 (the off twa controller) with the patch (invariants and invariants_support in the kernel) 0{offsite2}# tw_cli //offsite2> show Ctl Model (V)Ports Drives Units NotOpt RRate VRate BBU ------------------------------------------------------------------------ c0 9650SE-2LP 2 2 1 0 1 1 - //offsite2> ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/