From owner-freebsd-net@freebsd.org Tue May 18 19:19:04 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 370216546B8 for ; Tue, 18 May 2021 19:19:04 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fl5Qb4Bj2z4cFf for ; Tue, 18 May 2021 19:19:03 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-pg1-x529.google.com with SMTP id k15so7696195pgb.10 for ; Tue, 18 May 2021 12:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=QOYasK0WeyPLehV+GRhfdYDWaKcRWO03BZ/Fea4UeUg=; b=S1ZKzEAwvw6Zk9lPDuG75roQhaRfq42gFV8fBY/IYYSbSQYGQUCLm/C2hNkjSeejwP v3vDJoVeg4M48rIWkcVHmIcjS+3QX5tY0aOWT6mlyTzYW7iVwUZbJlbUSEq+z2yVocjL +r4GWWZ3udwx1nbHQAoEy1TZClYAWK69jhbnATXDRDjBvpGZHzlOkqTZvmUQADbzj4Vx niQ1uNCcLA/J9i7snsDr0w9wPb3deAMYUzXeEMu9PF03z3Hl5bEU2tcmgnT+cH58o2ri ckJIe1Wouk3cIeC1TfNwmUHgVWwslbv/L3uJG8fDZ8qz8iH0Jazzkt6flePlIY2sU4kg sVZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QOYasK0WeyPLehV+GRhfdYDWaKcRWO03BZ/Fea4UeUg=; b=XgQAEPz0oeN0Ogn03MpIgKpKKuoeYL2aWDLTuVGuQfoZ/RDeCdpKq53TosmU2b4YIW urFE7KIzxv5xlvKvjrwSz+3ofsCReR2+dxdwg//2yQRTUmw3FlcT0qluS1m4yAw6LTgT 86QlLd8tC/myT0dYGym3v2M6al/oLBdgRwT5pmCgKgSUob/Uvepx4LhG7P3UWt0f2R94 69spps6VxmFCnS3qoenTYEk126d3Utr6brYLJPNysI1fje3uRqFXAy7pKuXgnCiU6Wbk EydJ0aAtCQ56NQwx2QFz4OnS0UHjeJxlaRfRsk6yHFoAu61aAG5N4WSs+zRmyck8p4U+ SmMA== X-Gm-Message-State: AOAM532yTsDkZFCZtZbNThqEwwTuX+NWF9O2mC2Bp7QkINGGQh6Zg2YI w1erqZuEAUfAq8DuajnlEv1ixnhhavK6HOy1ZWIbFi3p9H4= X-Google-Smtp-Source: ABdhPJzK5WNJYBgrIb2oK3XmqhGf2SZulalXy6BZ39j/eU71BWrT0ZuYFQ1C/ZqTlC5zRN3lrdLfnkjn3I1NR0z07L8= X-Received: by 2002:a63:f955:: with SMTP id q21mr6840828pgk.448.1621365542190; Tue, 18 May 2021 12:19:02 -0700 (PDT) MIME-Version: 1.0 From: Ryan Stone Date: Tue, 18 May 2021 15:18:51 -0400 Message-ID: Subject: rip6_output not in net epoch across call to ip6_setpktopts() To: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Fl5Qb4Bj2z4cFf X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=S1ZKzEAw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2607:f8b0:4864:20::529 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-0.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::529:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::529:from:127.0.2.255]; NEURAL_SPAM_LONG(1.00)[0.996]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::529:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 19:19:04 -0000 Recently at work we saw a panic in ip6_setpktopt() while it's using an ifnet returned by ifnet_byindex, here: https://cgit.freebsd.org/src/tree/sys/netinet6/ip6_output.c#n2969 The issue seems to be that rip6_output() calls into ip6_setpktopts() outside of the net epoch. Should I just wrap the setpktopts call in a net epoch enter/exit, or does anybody think that there's something cleverer that should be done there?