From owner-freebsd-sysinstall@FreeBSD.ORG  Tue Jul 13 15:00:17 2010
Return-Path: <owner-freebsd-sysinstall@FreeBSD.ORG>
Delivered-To: freebsd-sysinstall@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2FB891065679
	for <freebsd-sysinstall@hub.freebsd.org>;
	Tue, 13 Jul 2010 15:00:17 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 202BA8FC1C
	for <freebsd-sysinstall@hub.freebsd.org>;
	Tue, 13 Jul 2010 15:00:17 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6DF0GT2022383
	for <freebsd-sysinstall@freefall.freebsd.org>;
	Tue, 13 Jul 2010 15:00:16 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6DF0GqK022374;
	Tue, 13 Jul 2010 15:00:16 GMT (envelope-from gnats)
Date: Tue, 13 Jul 2010 15:00:16 GMT
Message-Id: <201007131500.o6DF0GqK022374@freefall.freebsd.org>
To: freebsd-sysinstall@FreeBSD.org
From: Garrett Cooper <yanegomi@gmail.com>
Cc: 
Subject: Re: bin/119077: [patch] sysinstall(8) - reading packages from index
	is extremely slow
X-BeenThere: freebsd-sysinstall@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garrett Cooper <yanegomi@gmail.com>
List-Id: Sysinstall Work <freebsd-sysinstall.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall>, 
	<mailto:freebsd-sysinstall-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sysinstall>
List-Post: <mailto:freebsd-sysinstall@freebsd.org>
List-Help: <mailto:freebsd-sysinstall-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall>, 
	<mailto:freebsd-sysinstall-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jul 2010 15:00:17 -0000

The following reply was made to PR bin/119077; it has been noted by GNATS.

From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org, michal.botka@seznam.cz
Cc:  
Subject: Re: bin/119077: [patch] sysinstall(8) - reading packages from index 
	is extremely slow
Date: Tue, 13 Jul 2010 07:52:47 -0700

 I don't think that this algorithm is correct, because instead of
 bisecting the set (like quicksort typically does), it's taking the
 first element, and then doing a bubble-like sort.
 
 Regardless of the correctness of the algorithm, if one is concerned
 about using quicksort, the replacement algorithm should be using qsort
 in libc (because it's more tested and most likely more correct).
 
 Thanks,
 -Garrett