From owner-freebsd-acpi@FreeBSD.ORG Sun Jun 21 14:17:49 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41D7D1065670 for ; Sun, 21 Jun 2009 14:17:49 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-ew0-f212.google.com (mail-ew0-f212.google.com [209.85.219.212]) by mx1.freebsd.org (Postfix) with ESMTP id BD5B58FC15 for ; Sun, 21 Jun 2009 14:17:48 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ewy8 with SMTP id 8so3161748ewy.43 for ; Sun, 21 Jun 2009 07:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=rVttqbRkA7fr0ILhrtSjKldIUBIr7nBBk+UNczsGhzc=; b=rBuUxJhdqNIFXsfuM9qjMed/jk0x3/IARSaLy3WmmLmwUDxJd8YRugicNXpNDfRJTD kfK97dCsrIhCq9o+rrE31sNRzSvXmAlxTqugjimnEoPE1dEFUDbNq55lD7/7ngxpcrTw fxdt+6z5cpOu06MfMOeyTZw7AHAYJ/Iz9Zcps= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=I5kNGF1XJcsmgj9Ac6Re+C4sqA2K7W1RD6m1LuoEG36PfUYEs+/gTS81J5hy++pbMe FA+egEe1gIkfRWBfLN41xcc2JrS3+S5Ym5SDQ/JI4a+36nRL3/mn+++f+8J8x03AcTBx /n/tcjioGMtRC1kCQJ0WvX8tV2NrvCPdgavM4= Received: by 10.210.53.5 with SMTP id b5mr3429739eba.79.1245593867848; Sun, 21 Jun 2009 07:17:47 -0700 (PDT) Received: from omega.lan (bl9-155-202.dsl.telepac.pt [85.242.155.202]) by mx.google.com with ESMTPS id 24sm3942503eyx.13.2009.06.21.07.17.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 21 Jun 2009 07:17:47 -0700 (PDT) Sender: Rui Paulo Message-Id: From: Rui Paulo To: freebsd-acpi@freebsd.org In-Reply-To: <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Sun, 21 Jun 2009 15:17:46 +0100 References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> X-Mailer: Apple Mail (2.935.3) Cc: Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2009 14:17:49 -0000 On 21 Jun 2009, at 15:08, Rui Paulo wrote: > On 21 Jun 2009, at 12:20, Michael wrote: > >> Hello, >> >> I wrote two new acpi modules last year and finally found the time >> to fix >> them, add some missing features and write man pages. > > Michael, this is great work! I'll review and see if we can ship it > with 8.0! Michael, this looks good, but there are two style nits that we need to fix. * we should try not going over the 80 column mark * add a empty new line before every return If you could send me a new patch for 8.0 with these fixes, I'll commit it (unless someone else has objections). Regards, -- Rui Paulo