From owner-freebsd-ports@freebsd.org Mon Jan 8 11:11:50 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65494E6496D for ; Mon, 8 Jan 2018 11:11:50 +0000 (UTC) (envelope-from SRS0=zOZR=ED=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2930976098 for ; Mon, 8 Jan 2018 11:11:49 +0000 (UTC) (envelope-from SRS0=zOZR=ED=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 49B772840C; Mon, 8 Jan 2018 12:11:46 +0100 (CET) Received: from illbsd.quip.test (ip-86-49-16-209.net.upcbroadband.cz [86.49.16.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id DA20528412; Mon, 8 Jan 2018 12:11:44 +0100 (CET) Subject: Re: 'pkg upgrade -f spamassassin' stops but doesn't restart spamd To: Eugene Grosbein , Michael Grimm , freebsd-ports@freebsd.org References: <76627A89-D7E9-4010-910B-5F25886E7E7E@ellael.org> <5A523873.2050001@quip.cz> <5A524855.2040901@grosbein.net> <5A5284CC.9050400@quip.cz> <5A528749.9070308@grosbein.net> <5A528A87.4050908@quip.cz> <5A528D36.4020409@grosbein.net> From: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: <5A5351F0.7050804@quip.cz> Date: Mon, 8 Jan 2018 12:11:44 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <5A528D36.4020409@grosbein.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 11:11:50 -0000 Eugene Grosbein wrote on 01/07/2018 22:12: > 08.01.2018 4:00, Miroslav Lachman wrote: > >> PRs are false alibi. Some of my PRs are open for more than 10 years. > > So were mine when I could not commit fixes myself. This is not excuse to be lazy and not make another one. > >> For all erroneous port there must be will on maintainer and committer side. >> And if "they" think this is not a bug > > If we have written policy (and we have in this case), and upgrade really break things, > sane committer will not think "this is not a bug". > > Again, do you have a PR with "how-to-repeat" scenario and a patch, > so I could take it? OK, let's move on. I can open PR if you are willing to help and commit some fixes. But can we first talk about what and how should be done? What is the right way to handle Apache module install / deinstall / upgrade? Because some modules are using code from Mk/bsd.apache.mk which do the wrong thing: .if defined(AP_FAST_BUILD) .if !target(ap-gen-plist) _USES_build+= 490:ap-gen-plist ap-gen-plist: .if defined(AP_GENPLIST) . if !exists(${PLIST}) @${ECHO} "===> Generating apache plist" @${ECHO} "%%APACHEMODDIR%%/%%AP_MODULE%%" >> ${PLIST} @${ECHO} "@postexec %D/sbin/apxs -e ${AP_MOD_EN} -n %%AP_NAME%% %D/%F" >> ${PLIST} @${ECHO} "@postunexec ${SED} -i '' -E '/LoadModule[[:blank:]]+%%AP_NAME%%_module/d' %D/%%APACHEETCDIR%%/httpd.conf" >> ${PLIST} @${ECHO} "@postunexec echo \"Don't forget to remove all ${MODULENAME}-related directives in your httpd.conf\"">> ${PLIST} . endif .endif .endif Some modules did similar thing in Makefile (or they did in the past). 1) Should install put something in to httpd.conf? 2) Should deinstall or upgrade remove something from httpd.conf? 3) Or as I suggested here https://lists.freebsd.org/pipermail/freebsd-ports/2017-October/110725.html should each module install own sample file in apache24/modules.d/? Miroslav Lachman