From owner-freebsd-current@FreeBSD.ORG  Sun Oct  2 12:27:59 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ADE8D16A41F
	for <current@freebsd.org>; Sun,  2 Oct 2005 12:27:59 +0000 (GMT)
	(envelope-from fli+freebsd-current@shapeshifter.se)
Received: from mx1.h3q.net (manticore.shapeshifter.se [212.37.5.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 399E143D46
	for <current@freebsd.org>; Sun,  2 Oct 2005 12:27:59 +0000 (GMT)
	(envelope-from fli+freebsd-current@shapeshifter.se)
Received: from localhost (localhost [127.0.0.1])
	by mx1.h3q.net (Postfix) with ESMTP id 2D08A1A764;
	Sun,  2 Oct 2005 14:27:58 +0200 (CEST)
Received: from mx1.h3q.net ([127.0.0.1])
	by localhost (manticore.shapeshifter.se [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id 47279-06; Sun,  2 Oct 2005 14:27:57 +0200 (CEST)
Received: from [192.168.0.94] (h4n2fls31o270.telia.com [217.208.199.4])
	by mx1.h3q.net (Postfix) with ESMTP id 283641A744;
	Sun,  2 Oct 2005 14:27:57 +0200 (CEST)
Message-ID: <433FD24E.4030903@shapeshifter.se>
Date: Sun, 02 Oct 2005 14:27:58 +0200
From: Fredrik Lindberg <fli+freebsd-current@shapeshifter.se>
User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050928)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Benjamin Lutz <benlutz@datacomm.ch>
References: <433F6018.2050900@datacomm.ch> <433F976F.6090501@samsco.org>
	<433FB9B9.9020207@shapeshifter.se> <433FCBC1.10401@datacomm.ch>
In-Reply-To: <433FCBC1.10401@datacomm.ch>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: at mail.hamnpolare.net
Cc: current@freebsd.org
Subject: Re: Linksys EG1032 rev. 3 patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Oct 2005 12:27:59 -0000

Benjamin Lutz wrote:
>>>Sounds like the if_sk driver needs to be made more intelligent so that
>>>it doesn't try to claim this card, yes?
>>>
>>
>>Something like this...
> 
> 
> Shouldn't this be applied to the re and maybe the nge driver as well
> then? To prevent them from trying to attach to the other revisions?

Yes, you are probably right. I realized this too, a few moments after
I sent my previous mail.

> The revision of the EG1032 that uses the Realtek chip is 0x10, according
> to pciconf. (Full output for completeness' sake:
> 
> re0@pci2:10:0:  class=0x020000 card=0x00241737 chip=0x10321737 rev=0x10
> hdr=0x00
>     vendor   = 'Linksys'
>     device   = 'EG1032 Gigabit Ethernet'
>     class    = network
>     subclass = ethernet
> )
> 

I don't think we need to take nge into account since it only
probes for NGE_VENDORID (0x100B) and NGE_DEVICEID (0x0022).

rev 3 0x10, should be claimed by re
rev 2(?) 0x12, should be claimed by sk
rev 1(?), claimed by nge(4)

	Fredrik