From owner-freebsd-hackers@freebsd.org Mon Feb 22 15:16:13 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B99AFAB001F for ; Mon, 22 Feb 2016 15:16:13 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 975C91CD5 for ; Mon, 22 Feb 2016 15:16:13 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 65e41693-d977-11e5-8de6-958346fd02ba X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Mon, 22 Feb 2016 15:17:33 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u1MFG2D6005742; Mon, 22 Feb 2016 08:16:02 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1456154162.1294.51.camel@freebsd.org> Subject: Re: MMC/SDIO stack under CAM From: Ian Lepore To: Russell Haley , Warner Losh Cc: Adrian Chadd , "freebsd-hackers@freebsd.org" , Alexander Motin , "freebsd-arm@freebsd.org" , Ilya Bakulin , NGie Cooper Date: Mon, 22 Feb 2016 08:16:02 -0700 In-Reply-To: References: <20140216111153.GA74858@olymp.kibab.com> <5C2CF572-360D-4CA0-81C7-18A5C455AED5@bsdimp.com> <20140224142642.GA32538@olymp.kibab.com> <53120EE8.1080600@bakulin.de> <5688F015.4090002@bakulin.de> <6942A46B-110B-4E1F-9DA1-F965009E8E92@FreeBSD.org> <38dd08fc2a5930d58b09e9bd3cb6d3e7@bakulin.de> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2016 15:16:13 -0000 On Sun, 2016-02-21 at 23:28 -0800, Russell Haley wrote: > On Mon, Feb 15, 2016 at 9:33 PM, Warner Losh wrote: > > On Mon, Feb 15, 2016 at 7:22 AM, NGie Cooper > > wrote: > > > > > > > > > On Feb 15, 2016, at 02:13, Ilya Bakulin > > > > wrote: > > > > > > > > On 2016-02-11 19:54, Stanislav Sedov wrote: > > > > > > On Feb 11, 2016, at 10:47 AM, Ilya Bakulin > > > > > > wrote: > > > > > > I'll use an excellent opportunity to post a small status > > > > > > update about > > > my work :-) > > > > > > * SDHC controller on Wandboard now works with the new > > > > > > stack; > > > > > > * SDIO block read now works! > > > > > > * camcontrol userland app is extended to support "mmcsdcmd" > > > > > > command > > > that allows to send MMC commands from userland apps directly to > > > the card > > > via pass(4) device -- now we can write WLAN driver in userland : > > > -D > > > > > Great news, userspace drivers are the best!:) > > > > > So what are the remaining pieces that prevent this work from > > > > > hitting > > > the HEAD? > > > > > -- > > > > > Stanislav Sedov > > > > > ST4096-RIPE > > > > > > > > Hi Stas, > > > > > > > > As I'm not a committer, someone needs to review my code and > > > > assist in > > > intergration into -HEAD :-) > > > > Currently nobody was able to do a review because of -ENOTIME. > > > > The only feature that is missing in the new stack (from my PoV) > > > > is > > > working with high-speed cards -- I just haven't implemented > > > switching to > > > high-speed mode yet. Although now it's possible to send required > > > commands > > > to the card and then switch controller speed -- all using > > > camcontrol > > > mmcsdcmd :-). > > > > > > > > Do you know anyone not on CC line who is able to help me with > > > > this? Or > > > maybe you could even find some time yourself? > > > > > > Hi Ilya, > > > Could you please post the patch to phrabricator and CC the > > > interested > > > parties/me? > > > > > > > It's been up on phab for a while. There's been some comments on it. > > There's > > some > > things wrong still that I've been meaning to get bcak to Ilya on. > > > > When it is ready, I plan on committing this. It goes hand in hand > > with the > > nvme CAM stuff > > I've been working on. > > > > Anybody can take a look at it: https://reviews.freebsd.org/D4761 > > > > I tried to apply the SDIO patch like this: > > mv ~/Downloads/D4761.diff /usr/patches > > Then from within my build jail: > cd /usr/src > patch < /usr/patches/D4761.diff > > and I wind up with the mmc source files in my root. What should my > working directory be when applying this patch? That's an annoying historical quirk of patch... for files in the patches where the path doesn't already exist in your filesystem it just creates the files in the current dir, unless you add -p0, which will make it create missing directories. (-p normally tells it how many leading dir nodes to strip from the paths found in the patches, but -p0 is magical in that it strips nothing but creates dirs). -- Ian