Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Apr 2015 02:08:36 +0000 (UTC)
From:      Sean Bruno <sbruno@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r282265 - head
Message-ID:  <201504300208.t3U28a8S087789@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: sbruno
Date: Thu Apr 30 02:08:36 2015
New Revision: 282265
URL: https://svnweb.freebsd.org/changeset/base/282265

Log:
  Setting PATH to anything is useless as a bare command.  Its only relevant
  if its set in the environement of each command seperately.
  
  Move the PATH setting to the NXBMAKE variable so its picked up to find
  the one-off gperf build for the native-xtools target.
  
  Pointed Out by: ngie

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1	Thu Apr 30 01:24:25 2015	(r282264)
+++ head/Makefile.inc1	Thu Apr 30 02:08:36 2015	(r282265)
@@ -1522,7 +1522,8 @@ cross-tools: .MAKE
 
 NXBENV=		MAKEOBJDIRPREFIX=${OBJTREE}/nxb \
 		INSTALL="sh ${.CURDIR}/tools/install.sh" \
-		VERSION="${VERSION}"
+		VERSION="${VERSION}" \
+		PATH=${PATH}:${OBJTREE}/gperf_for_gcc/usr/bin
 NXBMAKE=	${NXBENV} ${MAKE} \
 		TBLGEN=${OBJTREE}/nxb-bin/usr/bin/tblgen \
 		CLANG_TBLGEN=${OBJTREE}/nxb-bin/usr/bin/clang-tblgen \
@@ -1549,7 +1550,6 @@ native-xtools: .MAKE
 	${NXBMAKE} DIRPRFX=${_gperf}/ depend && \
 	${NXBMAKE} DIRPRFX=${_gperf}/ all && \
 	${NXBMAKE} DIRPRFX=${_gperf}/ DESTDIR=${OBJTREE}/gperf_for_gcc install
-	PATH=${PATH}:${OBJTREE}/gperf_for_gcc/usr/bin
 .endif
 	mkdir -p ${OBJTREE}/nxb-bin/bin
 	mkdir -p ${OBJTREE}/nxb-bin/sbin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201504300208.t3U28a8S087789>