Date: Thu, 22 Dec 2016 23:02:02 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: Ed Schouten <ed@nuxi.nl>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r310425 - in head/sys/dev/mlx4: mlx4_core mlx4_ib Message-ID: <20161222220202.y4us772z6hd43nni@ivaldir.etoilebsd.net> In-Reply-To: <CAPyFy2BmeRbjN6WtzbimgiFo42G5KC=%2BRLQopWnBpRLNzdfJRw@mail.gmail.com> References: <201612221826.uBMIQLFQ076247@repo.freebsd.org> <CABh_MKkCgE15=x2KknGZSVGmk6rB==o6MghCbO%2B3ubSS1Et91Q@mail.gmail.com> <CAPyFy2BmeRbjN6WtzbimgiFo42G5KC=%2BRLQopWnBpRLNzdfJRw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--dcexskdpxwkelirr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Dec 22, 2016 at 03:57:38PM -0500, Ed Maste wrote:
> On 22 December 2016 at 14:44, Ed Schouten <ed@nuxi.nl> wrote:
> > 2016-12-22 19:26 GMT+01:00 Ed Maste <emaste@freebsd.org>:
> >> Log:
> >> mlx: avoid use of __DATE__ to make build reproducible
> >
> > Out of curiosity, are we planning on adding -Wdate-time or
> > -Werror=3Ddate-time to our default CFLAGS? If so, awesome!
>=20
> I hadn't thought of it, but good idea. Maybe something like this for now:
>=20
> --- a/share/mk/bsd.sys.mk
> +++ b/share/mk/bsd.sys.mk
> @@ -88,6 +88,9 @@ CWARNFLAGS.clang+=3D -Wno-parentheses
> .if defined(NO_WARRAY_BOUNDS)
> CWARNFLAGS.clang+=3D -Wno-array-bounds
> .endif # NO_WARRAY_BOUNDS
> +.if ${MK_REPRODUCIBLE_BUILD} !=3D no
> +CWARNFLAGS.clang+=3D -Wdate-time
> +.endif # MK_REPRODUCIBLE_BUILD
> .endif # WARNS
>=20
+1
Bapt
--dcexskdpxwkelirr
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlhcTVMACgkQY4mL3PG3
PlppJg/9E2icSMeBbRlzNpa5FSV43VGlLi9653qXNoiIx317uWc6BYYXW6f8C5tn
oUDIxOt3VUCX1qwHePcB7a6V75GzgF9Elu72akduNuMSuhm44LWB/WZ1aW0/51AJ
KC5qhHc5WUB4mpk93WH55Bcw+ljxgmNmmL1662LdgCVDPxvAeQowaqz9FivHsXWL
QkEvhLUuWcGzaDZ30JYUA+Yg3iFCZG53zfUMvn+Z39XP1HZ+4Qj0SGQtCnolBAZJ
kTasdBwdPvIKMHhlGrDuEneWitbcSI/VebkvB3zv5eXpvYJldIqnd1qeJg5DshBL
am/SF0MxTWF0wsaYmQAo+X8KrbBYKCIZauQLcTDGbzi+HUT2yWNXitpnHbqpeY4u
Dpg3PatkpPSVuO5i3l2eiHz1v3a7LDKaIdY/O08gczgmVshGuAw/tix8G6zlPAXE
0dyAVcGm6B+brsP0UC1KwD2IlcuN8ABgNdWLucWs+rNUDplmhIc/kSJFD1yOP3E4
rktHVwuJmMvei6AjGFc0SsuIY06Jzvy56RxLaFtaR4+tBo0gDZLh3Zk0+BzVKBNP
cI1khLE84ex2El1sp1O10ScZK8U2+1OFEkgAaXP5riIksWSfHOAcMH5QfPNMCHTc
FZNB6Ac1hG6XBIjOTRL51cXVcRq8/kw96vr2qBbwksEdHeUDdxE=
=i88t
-----END PGP SIGNATURE-----
--dcexskdpxwkelirr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161222220202.y4us772z6hd43nni>