From owner-cvs-all Fri Mar 23 23:33:57 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 36E4D37B71A; Fri, 23 Mar 2001 23:33:48 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f2O7WwG39168; Fri, 23 Mar 2001 23:32:59 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200103231859.f2NIxWD09605@freefall.freebsd.org> Date: Fri, 23 Mar 2001 23:33:11 -0800 (PST) From: John Baldwin To: Hajimu UMEMOTO Subject: RE: cvs commit: src/include/arpa inet.h src/sys/netinet in.h src Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 23-Mar-01 Hajimu UMEMOTO wrote: > ume 2001/03/23 10:59:32 PST > > Modified files: > include/arpa inet.h > sys/netinet in.h > sys/sys types.h > lib/libc/net inet.3 inet_addr.c inet_lnaof.c > inet_makeaddr.c inet_neta.c inet_netof.c > inet_network.c > Log: > IPv4 address is not unsigned int. This change introduces in_addr_t. > > PR: 9982 > Adviced by: des > Reviewed by: -alpha and -net (no objection) > Obtained from: OpenBSD I don't recall seeing it on -alpha: > make cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../dev -I../../../include -D_KERNEL -include opt_global.h -elf -mno-fp-regs -ffixed-8 -Wa,-mev56 -elf ../../alpha/alpha/genassym.c In file included from ../../sys/types.h:125, from ../../sys/param.h:56, from ../../alpha/alpha/genassym.c:40: machine/endian.h:62: redefinition of `in_addr_t' ../../sys/types.h:76: `in_addr_t' previously declared here It seems i386 is evil and doesn't use in_addr_t or in_port_t in its machine/endian.h. This probably breaks ia64 as well. Will you move in_port_t into sys/types.h as well and then convert the i386 endian.h to use the right types? -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message